Closed Bug 1431105 Opened 5 years ago Closed 5 years ago
Console API should propagate the prefix when set by a JSM
No description provided.
Patch already reviewed.
Assignee: nobody → amarchesini
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/056265a8a2ff Prefix in Console when used by JSM, r=smaug
Backed out for devtools failures on browser_webconsole_check_stubs_console_api.js Log: https://treeherder.mozilla.org/logviewer.html#?job_id=156897275&repo=mozilla-inbound&lineNumber=8943 Rev: https://hg.mozilla.org/integration/mozilla-inbound/rev/d2e350ad4b9133b4ccf52c883ce62e63060d5350
I need help with updating the stub files for the Console. Can you take a look?
Flags: needinfo?(amarchesini) → needinfo?(bgrinstead)
(In reply to Andrea Marchesini [:baku] from comment #4) > I need help with updating the stub files for the Console. Can you take a > look? So this adds an empty prefix string to all messages, even those that come from content. This is fine with me, but the packets generated for our unit tests need to change - this can be done via: `./mach test devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/browser_webconsole_update_stubs_console_api.js`. I did it locally and pushed this up to reviewboard here. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0fec2ebcd2b023a6c2932ebfdfa6d99cd89d626a
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6405716d757d Prefix in Console when used by JSM, r=bgrins, r=smaug
Comment on attachment 8943323 [details] Bug 1431105 - Prefix in Console when used by JSM, https://reviewboard.mozilla.org/r/213644/#review219450
Attachment #8943323 - Flags: review?(bgrinstead)
You need to log in before you can comment on or make changes to this bug.