1431105 - Console API should propagate the prefix when set by a JSM

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: prefix.patch

Patch already reviewed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/056265a8a2ff
Prefix in Console when used by JSM, r=smaug

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for devtools failures on browser_webconsole_check_stubs_console_api.js

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=156897275&repo=mozilla-inbound&lineNumber=8943
Rev: https://hg.mozilla.org/integration/mozilla-inbound/rev/d2e350ad4b9133b4ccf52c883ce62e63060d5350

Comment 4

[Andrea Marchesini [:baku]]

I need help with updating the stub files for the Console. Can you take a look?

Comment 5

[Brian Grinstead [:bgrins]]

Attachment: Bug 1431105 - Prefix in Console when used by JSM,

Review commit: https://reviewboard.mozilla.org/r/213644/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213644/

Comment 6

[Brian Grinstead [:bgrins]]

(In reply to Andrea Marchesini [:baku] from comment #4)
> I need help with updating the stub files for the Console. Can you take a
> look?

So this adds an empty prefix string to all messages, even those that come from content. This is fine with me, but the packets generated for our unit tests need to change - this can be done via: `./mach test devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/browser_webconsole_update_stubs_console_api.js`. I did it locally and pushed this up to reviewboard here. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0fec2ebcd2b023a6c2932ebfdfa6d99cd89d626a

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6405716d757d
Prefix in Console when used by JSM, r=bgrins, r=smaug

Comment 8

[Brian Grinstead [:bgrins]]

Comment on attachment 8943323 [details]
Bug 1431105 - Prefix in Console when used by JSM,

https://reviewboard.mozilla.org/r/213644/#review219450

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/6405716d757d