Closed Bug 1431105 Opened 2 years ago Closed 2 years ago

Console API should propagate the prefix when set by a JSM

Categories

(Core :: DOM: Core & HTML, enhancement)

58 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: baku, Assigned: baku)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch prefix.patchSplinter Review
Patch already reviewed.
Assignee: nobody → amarchesini
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/056265a8a2ff
Prefix in Console when used by JSM, r=smaug
I need help with updating the stub files for the Console. Can you take a look?
Flags: needinfo?(amarchesini) → needinfo?(bgrinstead)
(In reply to Andrea Marchesini [:baku] from comment #4)
> I need help with updating the stub files for the Console. Can you take a
> look?

So this adds an empty prefix string to all messages, even those that come from content. This is fine with me, but the packets generated for our unit tests need to change - this can be done via: `./mach test devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/browser_webconsole_update_stubs_console_api.js`. I did it locally and pushed this up to reviewboard here. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0fec2ebcd2b023a6c2932ebfdfa6d99cd89d626a
Flags: needinfo?(bgrinstead)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6405716d757d
Prefix in Console when used by JSM, r=bgrins, r=smaug
https://hg.mozilla.org/mozilla-central/rev/6405716d757d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.