Closed
Bug 1431135
Opened 8 years ago
Closed 8 years ago
add bug status css class to markup
Categories
(bugzilla.mozilla.org :: User Interface, enhancement)
Tracking
()
RESOLVED
FIXED
People
(Reporter: pascalc, Unassigned)
Details
Attachments
(1 file)
The modal view has no class selector allowing styling the bug status at the top of the page, the generated markup is:
<div class="value">
<span id="field-value-status_summary">
<b>NEW
</b>
<div id="status-assignee">Unassigned
</div>
</span>
</div>
The old view at least had the class on the body tag:
<body class="bugzilla-mozilla-org skin-standard bz_bug bz_status_NEW bz_product_Core bz_component_Layout:_View_Rendering bz_bug_1431128 bz_gravatar yui-skin-sam">
In that specific case, the class is bz_status_NEW.
That class should be added to the modal view markup either on the body like before or on a closer tag such as the span tag. That would allow styling the status of the bug (/ex: red for RESOLVED, green for NEW…) with a user style or user script.
|
||
Comment 1•8 years ago
|
||
This is here: https://github.com/mozilla-bteam/bmo/blob/master/extensions/BugModal/template/en/default/bug_modal/edit.html.tmpl#L232-L235
Proposed markup would be receive a quick review.
|
Reporter | |
Comment 2•8 years ago
|
||
(In reply to Dylan Hardison [:dylan] (he/him) from comment #1)
> This is here:
> https://github.com/mozilla-bteam/bmo/blob/master/extensions/BugModal/
> template/en/default/bug_modal/edit.html.tmpl#L232-L235
>
> Proposed markup would be receive a quick review.
https://github.com/mozilla-bteam/bmo/pull/380
Hopefully that works, thanks.
|
|
Reporter | |
Comment 3•8 years ago
|
||
Dylan, will the merged patch be pushed to https://bugzilla-dev.allizom.org/ or another staging site? It am not seeing it there so I guess I am not looking at the right server or commits to master are not deployed automatically to a staging instance?
Flags: needinfo?(dylan)
|
|
||
Comment 4•8 years ago
|
||
dev isn't automatically updated (staging is, but staging is behind the vpn).
I'll push an update out to dev soon.
Not doing a push to prod this week as I spent too much time in developer-mode.
Flags: needinfo?(dylan)
|
|
||
Comment 5•8 years ago
|
||
Attachment #8945174 -
Flags: review+
|
|
||
Updated•8 years ago
|
Assignee: nobody → pascalc
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Assignee: pascalc → nobody
Component: User Interface: Modal → User Interface
You need to log in
before you can comment on or make changes to this bug.
Description
•