1431153 - Unused "cdm-insufficient-version" EME notification and string

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[:Gijs (he/him)]

browser-media.js has:

      case "cdm-insufficient-version":
        notificationId = "drmContentCDMInsufficientVersion";


this is the only use of that string, which was removed from browser.properties in bug 1314445, but we left this `case` block around by accident. I don't think platform will ever call it anymore, but we should probably tidy it up.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac4b2111cacea51c3fb553f2d21eddd9a874780b

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1431153 - Remove unused CDM version check path from browser-media.js

Bug 1314445 removed GMPService::GetPluginVersionForAPI and cleaned up code paths
around this that would notify users if the content decryption module (CDM) did
not satisfy version requirements. Some dead code appears to have been overlooked
and is removed by this patch.

Comment 3

[:Gijs (he/him)]

Comment on attachment 9003121 [details]
Bug 1431153 - Remove unused CDM version check path from browser-media.js

:Gijs (he/him) has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f52720def84
Remove unused CDM version check path from browser-media.js r=Gijs

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0f52720def84