1431155 - Move WindowState to testing/marionette/browser.js

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

In preparation of the window tracking work I want to move the WindowState
class from testing/marionette/wm.js, effectively leaving the file empty,
to testing/marionette/browser.js.  With patches for improving window
tracking we will not have to expose WindowState outside browser.js,
but moving it to that file first will make the patch a lot easier
to read.  This will mean that wm.js will essentially remain empty
for a short period, however, I trust this is acceptable.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1431155 - Move WindowState to Marionette browser module.

This moves the WindowState enum from testing/marionette/wm.js to
testing/marionette/browser.js in order to make it easier to apply
the forthcoming Marionette window tracking refactoring patches.
In other words, this patch functionally does not change anything.

Review commit: https://reviewboard.mozilla.org/r/213658/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213658/

Comment 2

[David Burns :automatedtester]

Comment on attachment 8943328 [details]
Bug 1431155 - Move WindowState to Marionette browser module.

https://reviewboard.mozilla.org/r/213658/#review219660

::: testing/marionette/wm.js:7
(Diff revision 1)
>   * License, v. 2.0. If a copy of the MPL was not distributed with this file,
>   * You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  "use strict";
>  
> -this.EXPORTED_SYMBOLS = ["WindowState"];
> +this.EXPORTED_SYMBOLS = [];

why arent you deleting this file?

Comment 3

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8943328 [details]
Bug 1431155 - Move WindowState to Marionette browser module.

https://reviewboard.mozilla.org/r/213658/#review219660

> why arent you deleting this file?

I said in the bug, but we need it again for https://bugzil.la/marionette-window-tracking.

Comment 4

[David Burns :automatedtester]

Comment on attachment 8943328 [details]
Bug 1431155 - Move WindowState to Marionette browser module.

https://reviewboard.mozilla.org/r/213658/#review219668

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4581da0d9525
Move WindowState to Marionette browser module. r=automatedtester

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ed62b395dc2
Backed out changeset 4581da0d9525 for failing Browser-chrome on browser/base/content/test/static/browser_all_files_referenced.js on a CLOSED TREE

Comment 7

[Andreas Tolfsen ❲:ato❳]

So it turns out there is a browser chrome test for unused files that fails: https://treeherder.mozilla.org/logviewer.html#?job_id=157156338&repo=autoland&lineNumber=4940

I will remove the reference from testing/marionette/jar.mn for the time being.

Comment 8

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8943328 [details]
Bug 1431155 - Move WindowState to Marionette browser module.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213658/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abe10e265f29
Move WindowState to Marionette browser module. r=automatedtester

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/abe10e265f29