1431166 - [Windows HiDPI] incorrect height of window control icons after moving window to low DPI screen

Status: NEW

(Core :: Widget: Win32, defect, P3)

Description

[Florian Quèze [:florian]]

Attachment: Screenshot

Steps to reproduce:
1. Use a computer with a HiDPI internal screen, and plug an external low DPI screen.
2. Start Firefox on the HiDPI screen.
3. Move that window to the low DPI screen.

Expected result:
as the window gets redisplayed at low DPI, the controls in the top right corner should adjust.

Actual result:
The height of the control icons is incorrect, causing them to not be vertically centered, and their background to overflow into the navigation toolbar. See attached screenshot.

Comment 1

[Florian Quèze [:florian]]

Additional details that may be relevant:
- it seems I was using the 'compact' density.
- my internal HiDPI screen is a touch screen.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Maybe a widget issue? Do we paint the window controls in the gfx or widget layer?

Comment 3

[Florian Quèze [:florian]]

(In reply to Panos Astithas [:past] (please ni?) from comment #2)
> Maybe a widget issue? Do we paint the window controls in the gfx or widget
> layer?

The code deciding the height is at https://searchfox.org/mozilla-central/rev/1f9b4f0f0653b129b4db1b9fc5e9068054afaac0/browser/base/content/browser-tabsintitlebar.js#191-197