Broken |mach artifact toolchain --from-build linux64-clang|

RESOLVED FIXED in Firefox 59

Status

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Grisha, Assigned: glandium)

Tracking

unspecified
mozilla59
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

Hitting this as part of running |mach bootstrap| on Fedora 25.

Isolated from |mach bootstrap|:

./mach artifact toolchain --from-build linux64-clang
Error running mach:

    ['artifact', 'toolchain', '--from-build', 'linux64-clang']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AttributeError: 'dict' object has no attribute 'file_url'

  File "/home/grisha/Code/mozilla-central/python/mozbuild/mozbuild/mach_commands.py", line 1360, in artifact_toolchain
    toolchains = tasks('toolchain')
  File "/home/grisha/Code/mozilla-central/python/mozbuild/mozbuild/mach_commands.py", line 1354, in tasks
    tasks = Kind.load(root_path, graph_config, kind_name).load_tasks(params, {})
  File "/home/grisha/Code/mozilla-central/taskcluster/taskgraph/generator.py", line 73, in load_tasks
    for task_dict in transforms(trans_config, inputs)]
  File "/home/grisha/Code/mozilla-central/taskcluster/taskgraph/transforms/task.py", line 1645, in check_run_task_caches
    for task in tasks:
  File "/home/grisha/Code/mozilla-central/taskcluster/taskgraph/transforms/task.py", line 1592, in check_task_dependencies
    for task in tasks:
  File "/home/grisha/Code/mozilla-central/taskcluster/taskgraph/transforms/task.py", line 1580, in check_task_identifiers
    for task in tasks:
  File "/home/grisha/Code/mozilla-central/taskcluster/taskgraph/transforms/task.py", line 1563, in chain_of_trust
    for task in tasks:
  File "/home/grisha/Code/mozilla-central/taskcluster/taskgraph/transforms/task.py", line 1457, in build_task
    'source': config.params.file_url(config.path),
glandium: you seen this one before?
Component: Build Config & IDE Support → Build Config
Flags: needinfo?(mh+mozilla)
Product: Firefox for Android → Core
This is a regression from bug 1430823.
Blocks: 1430823
Flags: needinfo?(mh+mozilla)
Note this was fixed in https://hg.mozilla.org/integration/mozilla-inbound/rev/3a8491857651 but I'd rather still get rid of the default params that mach artifact toolchain uses.
Assignee: nobody → mh+mozilla
Comment on attachment 8943511 [details]
Bug 1431193 - Use taskgraph.parameters.load_parameters_file in mach artifact toolchain.

https://reviewboard.mozilla.org/r/213848/#review219728

::: taskcluster/taskgraph/parameters.py:44
(Diff revision 2)
>      'filters': ['check_servo', 'target_tasks_method'],
>      'head_ref': get_head_ref,
>      'head_repository': 'https://hg.mozilla.org/mozilla-central',
>      'head_rev': get_head_ref,
>      'include_nightly': False,
> -    'level': '3',
> +    'level': lambda: os.environ.get('MOZ_SCM_LEVEL', '3'),

Could you move this defaulting into the mach command?  I'd rather not have other uses of the default parameters quietly depend on an environment variable..
Attachment #8943511 - Flags: review?(dustin) → review+
Comment on attachment 8943511 [details]
Bug 1431193 - Use taskgraph.parameters.load_parameters_file in mach artifact toolchain.

This changed enough that I'd rather get another review.
Attachment #8943511 - Flags: review+ → review?(dustin)
Comment on attachment 8943511 [details]
Bug 1431193 - Use taskgraph.parameters.load_parameters_file in mach artifact toolchain.

https://reviewboard.mozilla.org/r/213848/#review219882
Attachment #8943511 - Flags: review?(dustin) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/5c16f89d0551
Use taskgraph.parameters.load_parameters_file in mach artifact toolchain. r=dustin
https://hg.mozilla.org/mozilla-central/rev/5c16f89d0551
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.