Closed
Bug 1431368
Opened 6 years ago
Closed 6 years ago
Change from keypress to keydown per standards change
Categories
(Firefox :: WebPayments UI, enhancement, P1)
Firefox
WebPayments UI
Tracking
()
RESOLVED
FIXED
Firefox 60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
References
Details
(Whiteboard: [webpayments])
Attachments
(1 file)
Per https://mail.mozilla.org/pipermail/firefox-dev/2018-January/006069.html, we should be using keydown instead of keypress for non-printable keys such as ArrowDown, ArrowUp, etc that we currently use for navigating within the select dropwdown.
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8943568 [details] Bug 1431368 - Change from keypress to keydown per standards change. https://reviewboard.mozilla.org/r/213920/#review219886
Attachment #8943568 -
Flags: review?(MattN+bmo) → review+
|
||
Comment 3•6 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s db37a5ec3c578625a30fcaab9724e61cf7ef2d57 -d be1ce4548b2e: rebasing 443183:db37a5ec3c57 "Bug 1431368 - Change from keypress to keydown per standards change. r=MattN" (tip) merging toolkit/components/payments/res/components/rich-option.js merging toolkit/components/payments/res/components/rich-select.js merging toolkit/components/payments/test/mochitest/test_rich_select.html warning: conflicts while merging toolkit/components/payments/res/components/rich-option.js! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
| Comment hidden (mozreview-request) |
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/111877d357c6 Change from keypress to keydown per standards change. r=MattN
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/111877d357c6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Updated•6 years ago
|
Priority: -- → P1
Whiteboard: [webpayments]
|
||
Updated•6 years ago
|
Product: Toolkit → Firefox
Target Milestone: mozilla60 → Firefox 60
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•