Closed
Bug 1431433
Opened 7 years ago
Closed 7 years ago
Android emulator test configuration could be tidier
Categories
(Firefox for Android Graveyard :: Testing, enhancement, P1)
Firefox for Android Graveyard
Testing
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: gbrown, Assigned: gbrown)
References
Details
Attachments
(4 files)
38.64 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
4.27 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
6.34 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
3.36 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
I don't expect any change in functionality here.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9754d5281579c8b8b0e9a1a296e241f5a5acc837
Attachment #8943647 -
Flags: review?(jmaher)
Comment 2•7 years ago
|
||
Comment on attachment 8943647 [details] [diff] [review]
split out common configuration, remove obsolete features
Review of attachment 8943647 [details] [diff] [review]:
-----------------------------------------------------------------
nice!
Attachment #8943647 -
Flags: review?(jmaher) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5b90dd89e1a
Tidy and reorganize mozharness configuration for Android emulator tests; r=jmaher
Assignee | ||
Updated•7 years ago
|
Keywords: leave-open
Comment 4•7 years ago
|
||
bugherder |
Assignee | ||
Updated•7 years ago
|
Keywords: leave-open
Assignee | ||
Comment 5•7 years ago
|
||
Left over from buildbot days!
Attachment #8943811 -
Flags: review?(jmaher)
Assignee | ||
Comment 6•7 years ago
|
||
The default ports are slightly different, but work just as well!
Attachment #8943812 -
Flags: review?(jmaher)
Assignee | ||
Comment 7•7 years ago
|
||
Last few things that were bugging me - that's all for now!
Attachment #8943814 -
Flags: review?(jmaher)
Assignee | ||
Comment 8•7 years ago
|
||
All patches applied and everything working just the same:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e61f498b2e5ac155cb085653cbdf743ec9ab312
Comment 9•7 years ago
|
||
Comment on attachment 8943811 [details] [diff] [review]
remove support for reftest-debug, crashtest-debug, jsreftest-debug suites
Review of attachment 8943811 [details] [diff] [review]:
-----------------------------------------------------------------
very cool!
Attachment #8943811 -
Flags: review?(jmaher) → review+
Comment 10•7 years ago
|
||
Comment on attachment 8943812 [details] [diff] [review]
remove ssl-port, http-port configuration
Review of attachment 8943812 [details] [diff] [review]:
-----------------------------------------------------------------
do we need to consider the case of autophone?
Attachment #8943812 -
Flags: review?(jmaher) → review+
Comment 11•7 years ago
|
||
Comment on attachment 8943814 [details] [diff] [review]
miscellaneous tidying
Review of attachment 8943814 [details] [diff] [review]:
-----------------------------------------------------------------
looking good
Attachment #8943814 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 12•7 years ago
|
||
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #10)
> do we need to consider the case of autophone?
I checked with :bc -- it's okay.
Assignee | ||
Updated•7 years ago
|
Priority: -- → P1
Comment 13•7 years ago
|
||
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a4dcd3475e0
Cleanup support for obsolete -debug Android test suites; r=jmaher
https://hg.mozilla.org/integration/mozilla-inbound/rev/56917373186f
Remove ssl_port/http_port from Android mozharness configs; r=jmaher
https://hg.mozilla.org/integration/mozilla-inbound/rev/84f55fec8d39
Miscellaneous simplifications to android_emulator_unittest.py; r=jmaher
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8a4dcd3475e0
https://hg.mozilla.org/mozilla-central/rev/56917373186f
https://hg.mozilla.org/mozilla-central/rev/84f55fec8d39
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•