1431436 - [FTL] Add rich editor support for PLATFORM() selector

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P2)

Description

[Matjaz Horvat [:mathjazz]]

It can also be in an attribute.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/814

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/819

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/ad264b90afc5156b64911754530e148c428bdff1
Bug 1431436: [FTL] Support select expressions in read-only display (#814)

Improve read-only presentation of FTL Messages to support select
expressions, including `PLATFORM()`. Select expressions can be either
in a value or in attributes. They can be surrounded by other elements
of any type.

FTL Message that contains any combination of elements of type
`TextElement`, `ExternalArgument`, `MessageReference` and
`SelectExpression` in their value or attribute or both are now
supportedcin read-only display.

There are two read-only displays the we use in the UI and have been
improved as part of this patch:

1. Simplified string preview:
* Now uses default variants of select expressions instead of first.
* Backend and frontend code are now unified.

2. Original string presentation.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/f36a271cbc75609fbd83cbbe95a67b3705c272e9
Fix bug 1431436: [FTL] Support select expressions in editor (#819)

Improve FTL editor to support presenting and saving select expressions,
including `PLATFORM()`. Select expressions can be either in a value or
in attributes. They can be surrounded by other elements of any type.

FTL Messages that contain any combination of elements of type
`TextElement`, `ExternalArgument`, `MessageReference` and
`SelectExpression` in their value or attributes or both are now supported
in the editor.

Other improvements:
* Allow turning simple strings into complex string via source editor.
* Detect strings with parse errors as not supported in rich FTL editor
  and prevent switching to FTL editor until they are fixed.