1431459 - Convert mozrunner constructor to a builder API

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

The PR was originally submitted to the then-canonical repository
[1], but mozrunner will since have moved in-tree under
testing/mozbase/rust/mozrunner with [2].

  [1] https://github.com/jgraham/rust_mozrunner/pull/17
  [2] https://bugzil.la/1429511

Comment 1

[Andreas Tolfsen ❲:ato❳]

jgraham: Do you want to have a go at re-submitting your patch to central?

Comment 2

[James Graham [:jgraham]]

Attachment: Bug 1431459 - Update rust_mozrunner to use a Builder API,

This is a major API revision to replace the Python-like API with
something more idiomatically Rust. In particular you now create a
FirefoxRunner object and then call start() and end up with a
FirefoxProcess. This is pretty similar to the Command builder in std.

Review commit: https://reviewboard.mozilla.org/r/217146/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217146/

Comment 3

[James Graham [:jgraham]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b82eea34f937eec4fbb73c5eeef3204f5e3c2d71

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8947439 [details]
Bug 1431459 - Update rust_mozrunner to use a Builder API,

https://reviewboard.mozilla.org/r/217146/#review222952

Thanks for doing this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b4c20449b76
Update rust_mozrunner to use a Builder API, r=ato

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6b4c20449b76