1431566 - avoid setState race in TopSites and use eslint to prevent similar

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Referencing this.state directly in a call to setState is racy.  I'll attach a patch the fixes the instance we've got of this, and prevents it in the future by turning on an eslint rule.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

I've also filed https://github.com/yannickcr/eslint-plugin-react/issues/1648 to allow eslint to also detect uses of this.state in the same synchronous scope after calling this.setState (where either the callback or componentDidUpdate should have been used instead).  If/when that gets implemented, I'll file a separate bug to use that to clean those races out of our codebase as well.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/713db8e350135f25f23758ce0c86078c9cc1ce46
fix(TopSites) avoid setState race in TopSites and use eslint to prevent similar, bug 1431566

https://github.com/mozilla/activity-stream/commit/e1abbdfe10e76ed6766979b4065b4928f77d619a
Merge pull request #3949 from dmose/setState-race-bug-1431566

fix(TopSites) avoid setState race in TopSites , use eslint to prevent similar, fixes bug 1431566

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/549d78378587