1431621 - Sandbox MinGW Compilation error: error: stray ‘\’ in program

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Tom Ritter [:tjr]]

> 0:01.74 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/base/win/scoped_handle.h:21:59: error: stray ‘\’ in program
> 0:01.74  #define BASE_WIN_GET_CALLER __builtin_extract_return_addr(\\

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1431621 Remove the gcc variant of BASE_WIN_GET_CALLER, because MinGW defines _ReturnAddress()

Review commit: https://reviewboard.mozilla.org/r/214232/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214232/

Comment 2

[Jacek Caban]

Current mingw-w64 has _ReturnAddress() defined to __builtin_return_address(0). It does not use __builtin_extract_return_addr. I'm not sure if it's needed for platforms we care about (if it is, it should be fixed in mingw-w64).

That said, it may be a good idea to remove GCC variant in m-c and change defined(COMPILER_MSVC) to defined (WIN32) instead.

Comment 3

[Tom Ritter [:tjr]]

Comment on attachment 8943877 [details]
Bug 1431621 Remove the gcc variant of BASE_WIN_GET_CALLER, because MinGW defines _ReturnAddress()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214232/diff/1-2/

Comment 4

[Tom Ritter [:tjr]]

(In reply to Jacek Caban from comment #2)
> Current mingw-w64 has _ReturnAddress() defined to
> __builtin_return_address(0). It does not use __builtin_extract_return_addr.
> I'm not sure if it's needed for platforms we care about (if it is, it should
> be fixed in mingw-w64).

The gcc documentation indicates we probably don't care about that situation; I don't think you can run Windows on a sparc.

> That said, it may be a good idea to remove GCC variant in m-c and change
> defined(COMPILER_MSVC) to defined (WIN32) instead.

Yea, I think we can drop the gcc variant.

Comment 5

[Tom Ritter [:tjr]]

Upstream: https://bugs.chromium.org/p/chromium/issues/detail?id=803845

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=69bfee9aea3c5b2a4d7f1ad6f6d7c8baf73d6833

Comment 6

[Bob Owen (:bobowen)]

Can you add the patch file here as well, please:
security/sandbox/chromium-shim/patches/with_update/

and the name to:
security/sandbox/chromium-shim/patches/with_update/patch_order.txt

Comment 7

[Tom Ritter [:tjr]]

Comment on attachment 8943877 [details]
Bug 1431621 Remove the gcc variant of BASE_WIN_GET_CALLER, because MinGW defines _ReturnAddress()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214232/diff/2-3/

Comment 8

[Tom Ritter [:tjr]]

Done!

Comment 9

[Bob Owen (:bobowen)]

Comment on attachment 8943877 [details]
Bug 1431621 Remove the gcc variant of BASE_WIN_GET_CALLER, because MinGW defines _ReturnAddress()

https://reviewboard.mozilla.org/r/214232/#review220048

Thanks.

Comment 10

[Tom Ritter [:tjr]]

Patch land order: 1431621 (this bug), 1431801, 1431807, 1431825

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e41201152dd
Remove the gcc variant of BASE_WIN_GET_CALLER, because MinGW defines _ReturnAddress() r=bobowen

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/6e41201152dd