1431738 - Disable TFO on release for now

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P1)

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: bug_make_tfo_early_bata_or_nightly_only.patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf09b4d00654
We will disable TFO on late beta and release. r=jduell

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/bf09b4d00654

Comment 4

[Liz Henry (:lizzard)]

Dragana or Jason, does this need uplift to beta 59? Is TFO disabled in 59 after early beta?

Comment 5

[Julien Cristau [:jcristau]]

as far as I can tell it's set to stay enabled right now for windows and mac in https://hg.mozilla.org/releases/mozilla-beta/file/default/modules/libpref/init/all.js#l4820

Comment 6

[Dragana Damjanovic [:dragana]]

Comment on attachment 8943950 [details] [diff] [review]
bug_make_tfo_early_bata_or_nightly_only.patch

Approval Request Comment
[Feature/Bug causing the regression]: TCP Fast Open feature. Turned on on Windows(bug 1426367) and on MacOS (bug 1426474)
[User impact if declined]: Let's disable TFO on release until we are sure we want it enabled.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no risk
[Why is the change risky/not risky?]: it is only turning of by changing a pref, no code change. Both code paths (feature turned off and on were running for some time.)
[String changes made/needed]: none

Comment 7

[Liz Henry (:lizzard)]

Comment on attachment 8943950 [details] [diff] [review]
bug_make_tfo_early_bata_or_nightly_only.patch

Turning off TFO for 59 late beta and release. Thanks Dragana!

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/13c900643140

Comment 9

[Andrei Vaida [:avaida]]

(In reply to Dragana Damjanovic [:dragana] from comment #6)
> [Feature/Bug causing the regression]: TCP Fast Open feature. Turned on on
> Windows(bug 1426367) and on MacOS (bug 1426474)
> [User impact if declined]: Let's disable TFO on release until we are sure we
> want it enabled.
> [Is this code covered by automated tests?]: no
> [Has the fix been verified in Nightly?]: yes
> [Needs manual test from QE? If yes, steps to reproduce]: no

Setting qe-verify- based on Dragana's assessment on manual testing needs.