Disable TFO on release for now

RESOLVED FIXED in Firefox 59

Status

()

defect
P1
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: dragana, Assigned: dragana)

Tracking

59 Branch
mozilla60
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox59+ fixed, firefox60 fixed)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 attachment)

No description provided.
Attachment #8943950 - Flags: review?(jduell.mcbugs) → review+
Keywords: checkin-needed
Pushed by aiakab@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf09b4d00654
We will disable TFO on late beta and release. r=jduell
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bf09b4d00654
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Dragana or Jason, does this need uplift to beta 59? Is TFO disabled in 59 after early beta?
Flags: needinfo?(jduell.mcbugs)
Flags: needinfo?(dd.mozilla)
as far as I can tell it's set to stay enabled right now for windows and mac in https://hg.mozilla.org/releases/mozilla-beta/file/default/modules/libpref/init/all.js#l4820
Comment on attachment 8943950 [details] [diff] [review]
bug_make_tfo_early_bata_or_nightly_only.patch

Approval Request Comment
[Feature/Bug causing the regression]: TCP Fast Open feature. Turned on on Windows(bug 1426367) and on MacOS (bug 1426474)
[User impact if declined]: Let's disable TFO on release until we are sure we want it enabled.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no risk
[Why is the change risky/not risky?]: it is only turning of by changing a pref, no code change. Both code paths (feature turned off and on were running for some time.)
[String changes made/needed]: none
Flags: needinfo?(dd.mozilla)
Attachment #8943950 - Flags: approval-mozilla-beta?
Comment on attachment 8943950 [details] [diff] [review]
bug_make_tfo_early_bata_or_nightly_only.patch

Turning off TFO for 59 late beta and release. Thanks Dragana!
Flags: needinfo?(jduell.mcbugs)
Attachment #8943950 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Dragana Damjanovic [:dragana] from comment #6)
> [Feature/Bug causing the regression]: TCP Fast Open feature. Turned on on
> Windows(bug 1426367) and on MacOS (bug 1426474)
> [User impact if declined]: Let's disable TFO on release until we are sure we
> want it enabled.
> [Is this code covered by automated tests?]: no
> [Has the fix been verified in Nightly?]: yes
> [Needs manual test from QE? If yes, steps to reproduce]: no

Setting qe-verify- based on Dragana's assessment on manual testing needs.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.