1431760 - Add new mutator interface that allows to set the principal and blob impl on a nsHostObjectURI mutator

Status: RESOLVED FIXED

(Core :: Networking, enhancement)

Description

[Valentin Gosu [:valentin] (he/him)]

> > -  RefPtr<nsHostObjectURI> uri;
> > +  nsCOMPtr<nsIURI> uri;
> > +  rv = NS_MutateURI(new nsHostObjectURI::Mutator())
> 
> would it make sense and not be to much work to pass info->mPrincipal,
> info->mBlobImpl as args to this specific Mutator?  or have setter for it on
> the mutator?

I'll add a new mutator interface that allows to set these attributes on the newly constructed URI.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1431760 - Add NS_MutateURI.Apply that allows calling methods declared in other interfaces implemented by NS_MutateURI::mMutator

* The method can be chained just as the other methods on NS_MutateURI.
* In case the mutator object does not implement the interface, mStatus will be set to an error code.
* This is useful when you are constructing a new URI and the type of the mutator is known. I expect a future patch will add a MaybeApply method, that does not set mStatus to an error code if the mutator does not implement the interface.
* This patch changes nsHostObjectProtocolHandler::NewURI to use the new method and avoid a static_cast<nsHostObjectURI*>(uri)

Review commit: https://reviewboard.mozilla.org/r/214450/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214450/

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8944123 [details]
Bug 1431760 - Add NS_MutateURI.Apply that allows calling methods declared in other interfaces implemented by NS_MutateURI::mMutator

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214450/diff/1-2/

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 8944123 [details]
Bug 1431760 - Add NS_MutateURI.Apply that allows calling methods declared in other interfaces implemented by NS_MutateURI::mMutator

https://reviewboard.mozilla.org/r/214450/#review220208

::: netwerk/base/nsIURIWithBlobImpl.idl:38
(Diff revision 2)
> +interface nsIBlobURIMutator : nsISupports
> +{
> +    /**
> +     * Associates a blobImpl to the mutated URI.
> +     */
> +    [must_use, noscript] nsIURIMutator setBlobImpl(in BlobImplPtr blobImpl);

nit: as this is noscript, why do we have to return nsIRUIMutator?  would save the non-obvious nullptr last arg when calling Apply via the NS_MutateURI helper

maybe all of noscript nsIURI*Mutator methods should return void for simplicity?  But it will not eb consistent... hard to say.

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8944123 [details]
Bug 1431760 - Add NS_MutateURI.Apply that allows calling methods declared in other interfaces implemented by NS_MutateURI::mMutator

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214450/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d89605a28513
Add NS_MutateURI.Apply that allows calling methods declared in other interfaces implemented by NS_MutateURI::mMutator r=mayhemer

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/d89605a28513