Closed Bug 1431774 Opened 2 years ago Closed 2 years ago

Simplify some nsIImageLoadingContent bits

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(7 files)

I ran into this while resurrecting my patches for bug 1132934.
These are all no-ops because the objects involved are already implementing one of the WebIDL interfaces that pulls in MozImageLoadingContent, and that's all script gets to see.

MozReview-Commit-ID: Io2mLHbv7qM
Attachment #8944002 - Flags: review?(nika)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
MozReview-Commit-ID: 3JpN3ZZVNg3
Attachment #8944004 - Flags: review?(nika)
MozReview-Commit-ID: KwWBFXNzWVx
Attachment #8944005 - Flags: review?(nika)
MozReview-Commit-ID: 1hm4WzQK93U
Attachment #8944010 - Flags: review?(nika)
MozReview-Commit-ID: 4n5BFQcHopU
Attachment #8944011 - Flags: review?(nika)
MozReview-Commit-ID: LKlo36VHKP5
Attachment #8944012 - Flags: review?(nika)
Attachment #8944002 - Flags: review?(nika) → review+
Comment on attachment 8944003 [details] [diff] [review]
part 2.  Make all attributes and methods on nsIImageLoadingContent noscript, since they're not used from JS

Review of attachment 8944003 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsIImageLoadingContent.idl
@@ +107,1 @@
>    

nit: While you are in here, perhaps remove this trailing whitespace :-)?
Attachment #8944003 - Flags: review?(nika) → review+
Attachment #8944004 - Flags: review?(nika) → review+
Comment on attachment 8944005 [details] [diff] [review]
part 4.  de-COM the image loading content observer APIs

Review of attachment 8944005 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsIImageLoadingContent.idl
@@ -103,5 @@
> -   * Same as removeNativeObserver but intended for scripted observers or
> -   * observers from another or without a document.
> -   */
> -  [noscript] void removeObserver(in imgINotificationObserver aObserver);
> -  

nevermind, looks like you get around to it :-P
Attachment #8944005 - Flags: review?(nika) → review+
Attachment #8944010 - Flags: review?(nika) → review+
Attachment #8944011 - Flags: review?(nika) → review+
Attachment #8944012 - Flags: review?(nika) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b32abc70b73c
part 1.  Remove a bunch of unnecessary QIs to nsIImageLoadingContent in JS.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc6b4a679a55
part 2.  Make all attributes and methods on nsIImageLoadingContent noscript, since they're not used from JS.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/36ecbfa0db66
part 3.  de-COM the image loading content loadingEnabled API.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/a414dcbea9c9
part 4.  de-COM the image loading content observer APIs.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f9b914468dc
part 5.  de-COM the image loading content setBlockedRequest API.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/04e629ae62cd
part 6.  de-COM the image loading content forceReload API.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/b94aa180ac8b
part 7.  de-COM the image loading content forceImageState API.  r=mystor
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.