1431774 - Simplify some nsIImageLoadingContent bits

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

I ran into this while resurrecting my patches for bug 1132934.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Remove a bunch of unnecessary QIs to nsIImageLoadingContent in JS

These are all no-ops because the objects involved are already implementing one of the WebIDL interfaces that pulls in MozImageLoadingContent, and that's all script gets to see.

MozReview-Commit-ID: Io2mLHbv7qM

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Make all attributes and methods on nsIImageLoadingContent noscript, since they're not used from JS

MozReview-Commit-ID: 5LqkMJP32J8

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. de-COM the image loading content loadingEnabled API

MozReview-Commit-ID: 3JpN3ZZVNg3

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. de-COM the image loading content observer APIs

MozReview-Commit-ID: KwWBFXNzWVx

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 5. de-COM the image loading content setBlockedRequest API

MozReview-Commit-ID: 1hm4WzQK93U

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: part 6. de-COM the image loading content forceReload API

MozReview-Commit-ID: 4n5BFQcHopU

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: part 7. de-COM the image loading content forceImageState API

MozReview-Commit-ID: LKlo36VHKP5

Comment 8

[Nika Layzell [:nika] (ooo, ni? for response)]

Comment on attachment 8944003 [details] [diff] [review]
part 2.  Make all attributes and methods on nsIImageLoadingContent noscript, since they're not used from JS

Review of attachment 8944003 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsIImageLoadingContent.idl
@@ +107,1 @@
>    

nit: While you are in here, perhaps remove this trailing whitespace :-)?

Comment 9

[Nika Layzell [:nika] (ooo, ni? for response)]

Comment on attachment 8944005 [details] [diff] [review]
part 4.  de-COM the image loading content observer APIs

Review of attachment 8944005 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsIImageLoadingContent.idl
@@ -103,5 @@
> -   * Same as removeNativeObserver but intended for scripted observers or
> -   * observers from another or without a document.
> -   */
> -  [noscript] void removeObserver(in imgINotificationObserver aObserver);
> -  

nevermind, looks like you get around to it :-P

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b32abc70b73c
part 1.  Remove a bunch of unnecessary QIs to nsIImageLoadingContent in JS.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc6b4a679a55
part 2.  Make all attributes and methods on nsIImageLoadingContent noscript, since they're not used from JS.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/36ecbfa0db66
part 3.  de-COM the image loading content loadingEnabled API.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/a414dcbea9c9
part 4.  de-COM the image loading content observer APIs.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f9b914468dc
part 5.  de-COM the image loading content setBlockedRequest API.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/04e629ae62cd
part 6.  de-COM the image loading content forceReload API.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/b94aa180ac8b
part 7.  de-COM the image loading content forceImageState API.  r=mystor

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/b32abc70b73c
https://hg.mozilla.org/mozilla-central/rev/dc6b4a679a55
https://hg.mozilla.org/mozilla-central/rev/36ecbfa0db66
https://hg.mozilla.org/mozilla-central/rev/a414dcbea9c9
https://hg.mozilla.org/mozilla-central/rev/2f9b914468dc
https://hg.mozilla.org/mozilla-central/rev/04e629ae62cd
https://hg.mozilla.org/mozilla-central/rev/b94aa180ac8b