1431791 - remove "Others" tab of certificate manager

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Dana Keeler (she/her) [:keeler]]

The "Others" tab of the certificate manager supposedly shows certificates in the user's profile that don't match any of the other categories. There are preexisting bugs with this implementation (e.g. hard-coded distrust entries that happen to have corresponding certificates show up in the "Servers" section, even if they're not end-entity certificates). Furthermore, the category is a bit pointless anyway, since certificates that are classified as "other" aren't going to be used for anything. We should just remove it and simplify nsCertTree.

Comment 1

[Dana Keeler (she/her) [:keeler]]

Note that while the text label is "Others", in code, "Others" can actually refer to email certificates from other people, and the "Others" tab is referred to as the "Orphan" tab.

Comment 2

[Dana Keeler (she/her) [:keeler]]

Attachment: bug 1431791 - remove "Others" tab from certificate manager

Review commit: https://reviewboard.mozilla.org/r/214394/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214394/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8944074 [details]
bug 1431791 - remove "Others" tab from certificate manager

https://reviewboard.mozilla.org/r/214394/#review220356

rs=me

Comment 4

[Mark Goodwin [:mgoodwin]]

Comment on attachment 8944074 [details]
bug 1431791 - remove "Others" tab from certificate manager

https://reviewboard.mozilla.org/r/214394/#review221600

Looks good to me!

Comment 5

[Dana Keeler (she/her) [:keeler]]

Thanks for the reviews!
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5133591360a2

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31f666b54f39
remove "Others" tab from certificate manager r=jaws,mgoodwin

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/31f666b54f39