Closed Bug 1432128 Opened 8 years ago Closed 8 years ago

[Regression] New sites do not appear on Top Sites

Categories

(Firefox for iOS :: Build & Test, defect)

Product:
Firefox for iOS
Component:
Build & Test
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios ? ---
fxios-v10.5 --- affected
fxios-v11.0 --- unaffected

People

(Reporter: isabel_rios, Unassigned)

Details

Not sure if this is a regression or a change in the implementation but now the new sites visited do not appear on top sites and so the XCUITests covering different scenarios there fail. This is happening on v10.x branch. See for example this test: ActivityStreamTest/testTopSitesAdd() -It checks that there are 5 top sites as default. -Goes to http://example.com taps to go back -Once in home panel screen it checks that there are 6 tops sites now Please see BB logs here: https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5a62a2a3a0f18c0001a44666/test/95a9816f-a509-4bda-bb12-6601fc0f1654/cf40c1b0-f6da-4bb2-9b4c-e951c9b17be7 This is the latest commit where tests work:https://github.com/mozilla-mobile/firefox-ios/commit/dbf510fdc27aad22fe1d42da936bc24db4ab4721 Investigating if this can be a regression introduced by one of the three commits landed after that one. Also some Unit Tests are failing since one of those commits (https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5a626a64ca685600012e3152) landed. Will investigate and open a separate bug for that if needed.
Ni Garvan since the last three commits are yours, any idea if any of those could have casued this regression or change in the behaviour? Thanks! I'm also investigating with BB because the simulators are launched in landscape but that looks like a separate issue.
status-fxios-v10.5: --- → affected
status-fxios-v11.0: --- → unaffected
Flags: needinfo?(gkeeley)
This commit is where the tests start to fail: 256dedc56649afaf44eba074cf6509a45b4360c2 It happens both on BB and running the tests locally on v10.x branch
Confirmed this is the 256dedc5 commit, master has an extra column in the favicon table, so we I to put that column back in one of the queries I changed for top sites.
Flags: needinfo?(gkeeley)
Should be fixed in next 20 mins...
Fixed the merge on v10.x: https://github.com/mozilla-mobile/firefox-ios/commit/6e300bf4480476d3fed10f2becc3ce7b8dd26f61
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.