Closed Bug 1432231 Opened 2 years ago Closed 2 years ago

Update compare-locales in elmo webapp to include python-fluent 0.6

Categories

(Webtools :: Elmo, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Pike, Assigned: Pike)

References

Details

When we get python-fluent 0.6 ready and in compare-locales, we need to pick that up in elmo for the diff view.

Not sure if there's actually something to change in the diff view for the syntax updates. We didn't support tags yet at all.

Stas? https://github.com/mozilla/elmo/blob/7dfebad36aef5fd9d884993c1f95969744c30f46/apps/pushes/views/diff.py#L262-L266 is the fluent-specific part of the diff view right now.
Flags: needinfo?(stas)
We should only show attributes if the id is a public one, i.e. doesn't start with a dash.
Flags: needinfo?(stas)
Actually, I think flod would be interested in seeing if entities add or remove attributes on private messages for sign-off.
(In reply to Axel Hecht [:Pike] from comment #2)
> Actually, I think flod would be interested in seeing if entities add or
> remove attributes on private messages for sign-off.

I definitely need to see all changes happening to the file, that includes private IDs.
Good point. I can't think of any other changes required but let me check again after I've updated compare-locales to python-fluent 0.6.
Blocks: 1426053
No longer blocks: 1424682
Fixed and deployed.
Assignee: nobody → l10n
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.