1432250 - feMorphology with zero radius should output the input image

Status: RESOLVED FIXED

(Core :: SVG, enhancement, P3)

Description

[Simon Fraser [no longer active]]

In Firefox, an feMorphology with radius=0 disables the filter (output is transparent), which is what SVG 1.1 specified.

In SVG 2, that has changed so that radius=0 should now behave like a no-op, outputting the input image.

Testcase at https://codepen.io/smfr/pen/mpozPz

Comment 1

[Markus Stange [:mstange]]

This line has to return aSources[0] instead of nullptr:
https://searchfox.org/mozilla-central/rev/b7e3ec2468d42fa59d86c03ec7afeb209813f1d4/gfx/src/FilterSupport.cpp#795

And these two tests need to be updated for the new behavior:
https://searchfox.org/mozilla-central/source/layout/reftests/svg/filters/feMorphology-radius-zero-01.svg
https://searchfox.org/mozilla-central/source/layout/reftests/svg/filters/feMorphology-radius-zero-02.svg

Comment 2

[Sebastian Zartner [:sebo]]

Attachment: Bug 1432250 - Output the input image for zero or negative radii for <feMorphology>. r=mstange

Comment 3

[Sebastian Zartner [:sebo]]

Attachment: Bug 1432250 - Updated tests for input image output for zero or negative radii for <feMorphology>. r=mstange

Depends on D63958

Comment 4

[Sebastian Zartner [:sebo]]

Thank you for accepting my patch, Markus! I don't have the rights to land it, so can you please do that for me?

Sebastian

Comment 5

[Markus Stange [:mstange]]

Sure - I'll kick off a try build first, though.

Comment 6

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=05af1af200632701d05b848774aa8cc7459c75c3

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a03f675e101
Output the input image for zero or negative radii for <feMorphology>. r=mstange
https://hg.mozilla.org/integration/autoland/rev/51ce5f13df5c
Updated tests for input image output for zero or negative radii for <feMorphology>. r=mstange

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/1a03f675e101
https://hg.mozilla.org/mozilla-central/rev/51ce5f13df5c

Comment 9

[Sebastian Zartner [:sebo]]

Thank you for merging the changes, Markus!

Sebastian