1432263 - Make matchBuckets string parsing the same everywhere it's done

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Drew Willcoxon :adw]

Bug 1426216 added its own matchBuckets parsing in order to determine whether a checkbox in the search preferences UI should be checked, and it's slightly different from the parsing that UnifiedComplete does.  It's possible for the checkbox not to reflect reality because of this difference.  In practice that shouldn't happen, though.  The only way for it to happen is if the user edited browser.urlbar.matchBuckets and didn't stick to the exact format that the checkbox expects.  But, there's no reason for these two places in the code to use different ways of parsing these strings.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1432263 - Make matchBuckets string parsing the same everywhere it's done.

Review commit: https://reviewboard.mozilla.org/r/214686/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214686/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8944504 [details]
Bug 1432263 - Make matchBuckets string parsing the same everywhere it's done.

https://reviewboard.mozilla.org/r/214686/#review220468

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d957a46ed50c
Make matchBuckets string parsing the same everywhere it's done. r=mak

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/d957a46ed50c

Comment 5

[Drew Willcoxon :adw]

Attachment: Beta patch

Approval Request Comment
[Feature/Bug causing the regression]:
This isn't a regression, but it's a followup from bug 1426216

[User impact if declined]:
None for most users.  Only users who manually edited the browser.urlbar.matchBuckets pref, or perhaps had an add-on or study that did, would possibly be affected.  The reason I'm asking for uplift is because there's no reason for this patch not to ship in the same release as the feature it's related to (the aforementioned bug 1426216)

[Is this code covered by automated tests?]:
Yes

[Has the fix been verified in Nightly?]:
No

[Needs manual test from QE? If yes, steps to reproduce]:
No

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
Small patch that simply factors out some common code

[String changes made/needed]:
None

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8945153 [details] [diff] [review]
Beta patch

Sounds like we should ship this fix in 59 to make sure UI behavior is consistent. Let's uplift for the beta 4 build.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/84a24eb373fa