Closed Bug 1432341 Opened 2 years ago Closed 2 years ago

Drawing of the column-rule is incorrect for the fragments of an inner multicol in nested multicols.

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: neerja, Assigned: dbaron)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

Open the attached test case ColumnRuleDrawingBroken.html in Nightly. You will see that the column-rules for the inner multicol fragments are extended beyond the size of the multicol.
These column-rules are not drawn at all on Firefox 57.
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Comment on attachment 8946062 [details]
Bug 1432341 - Simplify by using GetContentRectRelativeToSelf.

https://reviewboard.mozilla.org/r/216094/#review222120
Attachment #8946062 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8946063 [details]
Bug 1432341 - Rename functions that relate to column rules to have clearer names.

https://reviewboard.mozilla.org/r/216096/#review222122
Attachment #8946063 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8946064 [details]
Bug 1432341 - Draw column-rules with border-code in box-decoration-break: clone mode, rather than slice.

https://reviewboard.mozilla.org/r/216098/#review222124

I agree that the clone behaviour is preferable here!
Attachment #8946064 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8946065 [details]
Bug 1432341 - Add reftest for column-rule broken across columns.

https://reviewboard.mozilla.org/r/216100/#review222128
Attachment #8946065 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fe40d8edcf64beeac5573c00e1b33e88e838578
Bug 1432341 - Simplify by using GetContentRectRelativeToSelf.  r=mattwoodrow

https://hg.mozilla.org/integration/mozilla-inbound/rev/45d0f06fb923eabd1520754de60b0a29d7941dc1
Bug 1432341 - Rename functions that relate to column rules to have clearer names.  r=mattwoodrow

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d8a093e718c460c9252666a5e4d949a244483bf
Bug 1432341 - Draw column-rules with border-code in box-decoration-break: clone mode, rather than slice.  r=mattwoodrow

https://hg.mozilla.org/integration/mozilla-inbound/rev/ded3e23e2442aedea6392ceb02fe4b76b4b47f8c
Bug 1432341 - Add reftest for column-rule broken across columns.  r=mattwoodrow
You need to log in before you can comment on or make changes to this bug.