Closed
Bug 1432341
Opened 6 years ago
Closed 6 years ago
Drawing of the column-rule is incorrect for the fragments of an inner multicol in nested multicols.
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: neerja, Assigned: dbaron)
References
(Blocks 1 open bug)
Details
Attachments
(6 files)
2.16 KB,
text/html
|
Details | |
167.87 KB,
image/jpeg
|
Details | |
59 bytes,
text/x-review-board-request
|
mattwoodrow
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
mattwoodrow
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
mattwoodrow
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
mattwoodrow
:
review+
|
Details |
Open the attached test case ColumnRuleDrawingBroken.html in Nightly. You will see that the column-rules for the inner multicol fragments are extended beyond the size of the multicol.
Reporter | ||
Comment 1•6 years ago
|
||
Reporter | ||
Comment 2•6 years ago
|
||
These column-rules are not drawn at all on Firefox 57.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d91092a0c8fa18b3eec42669777482073891b07&group_state=expanded
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 8•6 years ago
|
||
mozreview-review |
Comment on attachment 8946062 [details] Bug 1432341 - Simplify by using GetContentRectRelativeToSelf. https://reviewboard.mozilla.org/r/216094/#review222120
Attachment #8946062 -
Flags: review?(matt.woodrow) → review+
Comment 9•6 years ago
|
||
mozreview-review |
Comment on attachment 8946063 [details] Bug 1432341 - Rename functions that relate to column rules to have clearer names. https://reviewboard.mozilla.org/r/216096/#review222122
Attachment #8946063 -
Flags: review?(matt.woodrow) → review+
Comment 10•6 years ago
|
||
mozreview-review |
Comment on attachment 8946064 [details] Bug 1432341 - Draw column-rules with border-code in box-decoration-break: clone mode, rather than slice. https://reviewboard.mozilla.org/r/216098/#review222124 I agree that the clone behaviour is preferable here!
Attachment #8946064 -
Flags: review?(matt.woodrow) → review+
Comment 11•6 years ago
|
||
mozreview-review |
Comment on attachment 8946065 [details] Bug 1432341 - Add reftest for column-rule broken across columns. https://reviewboard.mozilla.org/r/216100/#review222128
Attachment #8946065 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 12•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fe40d8edcf64beeac5573c00e1b33e88e838578 Bug 1432341 - Simplify by using GetContentRectRelativeToSelf. r=mattwoodrow https://hg.mozilla.org/integration/mozilla-inbound/rev/45d0f06fb923eabd1520754de60b0a29d7941dc1 Bug 1432341 - Rename functions that relate to column rules to have clearer names. r=mattwoodrow https://hg.mozilla.org/integration/mozilla-inbound/rev/8d8a093e718c460c9252666a5e4d949a244483bf Bug 1432341 - Draw column-rules with border-code in box-decoration-break: clone mode, rather than slice. r=mattwoodrow https://hg.mozilla.org/integration/mozilla-inbound/rev/ded3e23e2442aedea6392ceb02fe4b76b4b47f8c Bug 1432341 - Add reftest for column-rule broken across columns. r=mattwoodrow
Comment 13•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6fe40d8edcf6 https://hg.mozilla.org/mozilla-central/rev/45d0f06fb923 https://hg.mozilla.org/mozilla-central/rev/8d8a093e718c https://hg.mozilla.org/mozilla-central/rev/ded3e23e2442
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•