1432364 - stop supporting cot v1

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement)

Description

[Aki Sasaki (not active)]

Now that we've rolled out cotv2, let's stop supporting cotv1. This should make our cot verification more deterministic and maintainable, and will tie our tasks closer to the tree.

Let's wait for 59 to merge to release and make sure all the docker-image tasks are rebuilt with cotv2 supported task definitions. Let's make sure all the known ways to trigger+retrigger are cotv2 friendly - we may need to look at existing hooks and Treeherder's retrigger in bug 1420482.

Then let's:

- remove fuzzy task matching
- stop looking at commandlines
- stop maintaining docker image shas

We mainly need decision/action task verification, making sure our task definition came from one of those parent task types, and verifying our upstream artifacts haven't been altered at rest.

Comment 1

[Aki Sasaki (not active)]

Attachment: rr3 json-e==2.5.0

Releaserunner3 seems to have regressed to json-e==2.3.1. Let's fix that.

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 8944639 [details] [diff] [review]
rr3 json-e==2.5.0

https://hg.mozilla.org/build/puppet/rev/bd4d3f30787c

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/build/puppet/rev/ba69051bfe62
scriptworker 10.6.1 version bump. r=versionbump

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/build/puppet/rev/787b06d437b2
scriptworker 10.6.2. r=versionbump

Comment 6

[Aki Sasaki (not active)]

Attachment: bug 1432364 - remove comment about docker sha allowlists.

In bug 1328719, we added support for rebuilding the decision/action task definition via json-e.
In bug 1459705, we're killing support for cot v1, which relied on docker sha allowlists and decision task command parsing. Because we no longer use the docker sha allowlists, let's remove this comment.

Review commit: https://reviewboard.mozilla.org/r/247728/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247728/

Comment 7

[Aki Sasaki (not active)]

The patches to kill cotv1 are in bug 1459705.

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 8981602 [details]
bug 1432364 - remove comment about docker sha allowlists.

https://reviewboard.mozilla.org/r/247728/#review253786

Nice!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1cd2081db82
remove comment about docker sha allowlists. r=gps

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e1cd2081db82

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

The comment about scriptworker (meaning constants.py) at https://firefox-source-docs.mozilla.org/taskcluster/docs/taskcluster/docker-images.html#docker-registry-images looks like it needs updating for this bug.

Comment 12

[Aki Sasaki (not active)]

Attachment: doc update

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f39c27cbd36d
remove scriptworker requirement for docker images. r=nthomas

Comment 14

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/f39c27cbd36d

Comment 15

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/26be355967fd

Comment 16

[Tom Prince [:tomprince]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/2870a1a9df1b