Closed Bug 1432437 Opened 4 years ago Closed 4 years ago

Remove sycnhronous Bookmarks::changeBookmarkURI

Categories

(Toolkit :: Places, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: mak, Assigned: mak)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

A few tests are using changeBookmarkURI and should be refactored
https://searchfox.org/mozilla-central/search?q=changeBookmarkURI%28&path=
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Priority: P2 → P1
Depends on: 1432436
Comment on attachment 8945074 [details]
Bug 1432437 - Remove synchronous changeBookmarkURI.

https://reviewboard.mozilla.org/r/215290/#review221222
Attachment #8945074 - Flags: review?(standard8) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/8ebfca2b0c21
Remove synchronous changeBookmarkURI. r=standard8
Whiteboard: [fx-search] → [fxsearch]
Summary: Refactor tests using changeBookmarkURI → Remove sycnhronous Bookmarks::changeBookmarkURI
Flags: needinfo?(mak77)
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/ab4bbfaa0d37
Remove synchronous changeBookmarkURI. r=standard8
https://hg.mozilla.org/mozilla-central/rev/ab4bbfaa0d37
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Comment on attachment 8945074 [details]
Bug 1432437 - Remove synchronous changeBookmarkURI.

https://reviewboard.mozilla.org/r/215290/#review221804

::: services/sync/tests/unit/test_bookmark_tracker.js:595
(Diff revision 2)
>      _("Clean up.");
>      await cleanup();
>    }
>  });
>  
>  add_task(async function test_onItemChanged_changeBookmarkURI() {

FYI, feel free to just delete other subtests like this. The `test_async_*` subtests in this file should give us enough coverage.
You need to log in before you can comment on or make changes to this bug.