1432437 - Remove sycnhronous Bookmarks::changeBookmarkURI

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P1)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

A few tests are using changeBookmarkURI and should be refactored
https://searchfox.org/mozilla-central/search?q=changeBookmarkURI%28&path=

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1432437 - Remove synchronous changeBookmarkURI.

Review commit: https://reviewboard.mozilla.org/r/215290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215290/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8945074 [details]
Bug 1432437 - Remove synchronous changeBookmarkURI.

https://reviewboard.mozilla.org/r/215290/#review221222

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ebfca2b0c21
Remove synchronous changeBookmarkURI. r=standard8

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset 8ebfca2b0c21 (bug 1432437) for Xpcshell test failure on toolkit/components/places/tests/unit/test_sync_utils.js

https://treeherder.mozilla.org/logviewer.html#?job_id=158562023&repo=autoland&lineNumber=2630

https://hg.mozilla.org/integration/autoland/rev/d47d09e5efae8b19e8420a5192827ec07ce037b9

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=8ebfca2b0c21c64227ea273969c07137ca032153

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8945074 [details]
Bug 1432437 - Remove synchronous changeBookmarkURI.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/215290/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab4bbfaa0d37
Remove synchronous changeBookmarkURI. r=standard8

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ab4bbfaa0d37

Comment 8

[Lina Butler [:lina]]

Comment on attachment 8945074 [details]
Bug 1432437 - Remove synchronous changeBookmarkURI.

https://reviewboard.mozilla.org/r/215290/#review221804

::: services/sync/tests/unit/test_bookmark_tracker.js:595
(Diff revision 2)
>      _("Clean up.");
>      await cleanup();
>    }
>  });
>  
>  add_task(async function test_onItemChanged_changeBookmarkURI() {

FYI, feel free to just delete other subtests like this. The `test_async_*` subtests in this file should give us enough coverage.