1432486 - browser_sessionStorage_size.js is going to permafail when the Gecko version number is bumped to 61 on 2018-03-12

Status: VERIFIED FIXED

(Firefox :: Session Restore, enhancement)

Description

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/logviewer.html#?job_id=157875302&repo=try

Tim, it looks like you last touched this? This is failing because it depends on the FX_SESSION_RESTORE_DOM_STORAGE_SIZE_ESTIMATE_CHARS telemetry probe, which is set to expire in 61. Do we still need this probe? If so, please bump the expiration to something further out.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

I'd be in favor of removing the probe, we have 2k limit by default these days and we haven't heard any complaints. Mike, wdyt?

Comment 2

[Mike de Boer [:mikedeboer]]

I agree, 2k appears to be more than enough, so let's remove the probe.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: remove the probe

Green on Try.

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8945151 [details] [diff] [review]
remove the probe

Review of attachment 8945151 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks, Ryan!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/071a74086b2b
Remove the unneeded FX_SESSION_RESTORE_DOM_STORAGE_SIZE_ESTIMATE_CHARS probe. r=mikedeboer

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/071a74086b2b