1432487 - Change all listeners/delegates to be FooDelegate

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

We used to use Listener for things that just observed events and Delegate for things that had predicates or other two-way methods. We should just use Delegate for all of these types since it seems inevitable that they will have that type of use some day.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Is there an example of us needing to change a listener to a delegate? I think the Listener/Delegate naming follows general Android conventions.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Jim Chen [:jchen] [:darchons] from comment #1)
> Is there an example of us needing to change a listener to a delegate? I
> think the Listener/Delegate naming follows general Android conventions.

NavigationListener has onLoadUri() which is not just a listener.

Comment 3

[Dylan Roeh (:droeh) (he/him)]

Attachment: Rename GeckoView Listeners to Delegates

Renames *Listener to *Delegate.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8954499 [details] [diff] [review]
Rename GeckoView Listeners to Delegates

Review of attachment 8954499 [details] [diff] [review]:
-----------------------------------------------------------------

Might as well rename the methods here as well. Also please fix tests as well.

Comment 5

[Dylan Roeh (:droeh) (he/him)]

(In reply to Jim Chen [:jchen] [:darchons] from comment #4)
> Comment on attachment 8954499 [details] [diff] [review]
> Rename GeckoView Listeners to Delegates
> 
> Review of attachment 8954499 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Might as well rename the methods here as well. Also please fix tests as well.

Which method names? I renamed all of the *Listener* methods (and variables) I could find; the only stuff intentionally left using "Listener" in the name is BundleEventListener related.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

I meant what we talked about, renaming delegate methods to "onFoo" and "onFooRequest".

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b86e947b043
Rename all *Listeners to *Delegates and corresponding minor changes. r=snorp,jchen

Comment 8

[Cosmin Sabou [:CosminS]]

Backed out changeset for Android build bustages on several files that were renamed.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=2b86e947b043483e84d79c59772b7856609f5818&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=164998448

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=164998448&repo=mozilla-inbound&lineNumber=30955

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/23ed1a55d8768db3509ff7c291c0dd38a71e935a

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9ed97a0de02
Rename all *Listeners to *Delegates and corresponding minor changes. r=snorp,jchen

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/c9ed97a0de02