1432505 - Sandbox MinGW Compilation errors: SmartStub causes errors

Status: RESOLVED WONTFIX

(Core :: Security: Process Sandboxing, defect)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

0:02.10 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/sandbox/win/src/sidestep_resolver.cc: In member function ‘virtual NTSTATUS sandbox::SmartSidestepResolverThunk::Setup(const void*, const void*, const char*, const char*, const void*, void*, size_t, size_t*)’:
 0:02.10 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/sandbox/win/src/sidestep_resolver.cc:111:57: error: invalid conversion from ‘void (*)()’ to ‘const void*’ [-fpermissive]
 0:02.10                                       target_name, NULL, &SmartStub,
 0:02.10                                                          ^~~~~~~~~~
 0:02.10 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/sandbox/win/src/sidestep_resolver.cc:32:10: note:   initializing argument 5 of ‘virtual NTSTATUS sandbox::SidestepResolverThunk::Setup(const void*, const void*, const char*, const char*, const void*, void*, size_t, size_t*)’
 0:02.10  NTSTATUS SidestepResolverThunk::Setup(const void* target_module,
 0:02.10           ^~~~~~~~~~~~~~~~~~~~~
 0:02.10 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/sandbox/win/src/sidestep_resolver.cc:118:35: error: invalid conversion from ‘void (*)()’ to ‘const void*’ [-fpermissive]
 0:02.10                     thunk_storage, &SmartStub);
 0:02.10                                    ^~~~~~~~~~

 0:02.11 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/sandbox/win/src/sidestep_resolver.cc: In static member function ‘static void sandbox::SmartSidestepResolverThunk::SmartStub()’:
 0:02.11 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/sandbox/win/src/sidestep_resolver.cc:153:9: error: expected ‘(’ before ‘{’ token
 0:02.11    __asm {
 0:02.11          ^
 0:02.11 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/sandbox/win/src/sidestep_resolver.cc:154:5: error: ‘push’ was not declared in this scope
 0:02.11      push eax                  // Space for the jump.
 0:02.11      ^~~~







I don't really understand this one. But Bob it was okay to obliterate the function. I think I'll put a Release Assert to ensure it's not getting called.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Going to handle this error too:

 0:02.05 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/sandbox/win/src/sidestep_resolver.cc: In member function ‘virtual NTSTATUS sandbox::SmartSidestepResolverThunk::Setup(const void*, const void*, const char*, const char*, const void*, void*, size_t, size_t*)’:
 0:02.05 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/sandbox/win/src/sidestep_resolver.cc:111:57: error: invalid conversion from ‘void (*)()’ to ‘const void*’ [-fpermissive]
 0:02.05                                       target_name, NULL, &SmartStub,
 0:02.05                                                          ^~~~~~~~~~
 0:02.05 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/sandbox/win/src/sidestep_resolver.cc:32:10: note:   initializing argument 5 of ‘virtual NTSTATUS sandbox::SidestepResolverThunk::Setup(const void*, const void*, const char*, const char*, const void*, void*, size_t, size_t*)’
 0:02.05  NTSTATUS SidestepResolverThunk::Setup(const void* target_module,
 0:02.05           ^~~~~~~~~~~~~~~~~~~~~
 0:02.05 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/sandbox/win/src/sidestep_resolver.cc:118:35: error: invalid conversion from ‘void (*)()’ to ‘const void*’ [-fpermissive]
 0:02.05                     thunk_storage, &SmartStub);
 0:02.05                                    ^~~~~~~~~~

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1432505 Do not compile inline assembly on MinGW, instead break and abort

SmartStub is not called on MinGW, so we don't need to compile its
assembly (which gcc does not like.) To be sure this is safe, we
abort if it is called.

Review commit: https://reviewboard.mozilla.org/r/214952/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214952/

Comment 3

[Bob Owen (:bobowen)]

Comment on attachment 8944793 [details]
Bug 1432505 Do not compile inline assembly on MinGW, instead break and abort

https://reviewboard.mozilla.org/r/214952/#review220994

Clearing this, because it should be fixed by the patch in bug 1432381.

Comment 4

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Won't need this one