Closed
Bug 1432523
Opened 6 years ago
Closed 6 years ago
Switch pref to enable CSP violation events
Categories
(Core :: DOM: Security, enhancement, P3)
Core
DOM: Security
Tracking
()
RESOLVED
DUPLICATE
of bug 1472661
People
(Reporter: ckerschb, Assigned: baku)
References
Details
(Whiteboard: [domsecurity-backlog1] [domsecurity-active])
Attachments
(1 file)
1.15 KB,
patch
|
ckerschb
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Comment 1•6 years ago
|
||
I'm developing a polyfill for the Trusted Types (https://github.com/WICG/trusted-types), and as such, i'm creating & dispatching SecurityPolicyViolationEvents from JS. Having the event object enabled in release version of FF would definitely help :)
Assignee | ||
Comment 2•6 years ago
|
||
Assignee: nobody → amarchesini
Attachment #8992956 -
Flags: review?(ckerschb)
Assignee | ||
Updated•6 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-backlog1] → [domsecurity-backlog1] [domsecurity-active]
Reporter | ||
Comment 3•6 years ago
|
||
Comment on attachment 8992956 [details] [diff] [review] csp_enable.patch Review of attachment 8992956 [details] [diff] [review]: ----------------------------------------------------------------- Can you please find the thread on dev-platform, it's called [Intent to ship: CSP Violation DOM Events] and mention that we flip the pref now? thanks r=me
Attachment #8992956 -
Flags: review?(ckerschb) → review+
Reporter | ||
Comment 4•6 years ago
|
||
This Bug interfers with the changes within Bug 1476820. Please make sure violation events are enabled by default after the merge.
Reporter | ||
Updated•6 years ago
|
Summary: Switch pref to enable CSP violation reports → Switch pref to enable CSP violation events
Updated•6 years ago
|
Keywords: dev-doc-needed
Comment 5•6 years ago
|
||
I just landed bug 1476820. I considered changing the pref's value to match this bug's patch while doing so, but then I figured it's better to have a separate bug for that. baku, in modules/libpref/init/StaticPrefList.h, you'll need to change this: #ifdef NIGHTLY_BUILD # define PREF_VALUE true #else # define PREF_VALUE false #endif VARCACHE_PREF( "security.csp.enable_violation_events", security_csp_enable_violation_events, bool, PREF_VALUE ) #undef PREF_VALUE to this: VARCACHE_PREF( "security.csp.enable_violation_events", security_csp_enable_violation_events, bool, true )
Assignee | ||
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Updated•6 years ago
|
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•