1432523 - Switch pref to enable CSP violation events

Status: RESOLVED DUPLICATE of bug 1472661

(Core :: DOM: Security, enhancement, P3)

Comment 1

[Krzysztof Kotowicz]

I'm developing a polyfill for the Trusted Types (https://github.com/WICG/trusted-types), and as such, i'm creating & dispatching SecurityPolicyViolationEvents from JS. Having the event object enabled in release version of FF would definitely help :)

Comment 2

[Andrea Marchesini [:baku]]

Attachment: csp_enable.patch

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8992956 [details] [diff] [review]
csp_enable.patch

Review of attachment 8992956 [details] [diff] [review]:
-----------------------------------------------------------------

Can you please find the thread on dev-platform, it's called [Intent to ship: CSP Violation DOM Events] and mention that we flip the pref now? thanks

r=me

Comment 4

[Christoph Kerschbaumer [:ckerschb]]

This Bug interfers with the changes within Bug 1476820. Please make sure violation events are enabled by default after the merge.

Comment 5

[Nicholas Nethercote [inactive]]

I just landed bug 1476820. I considered changing the pref's value to match this bug's patch while doing so, but then I figured it's better to have a separate bug for that.

baku, in modules/libpref/init/StaticPrefList.h, you'll need to change this:

  #ifdef NIGHTLY_BUILD
  # define PREF_VALUE true
  #else
  # define PREF_VALUE false
  #endif
  VARCACHE_PREF(
    "security.csp.enable_violation_events",
     security_csp_enable_violation_events,
    bool, PREF_VALUE
  )
  #undef PREF_VALUE

to this:

  VARCACHE_PREF(
    "security.csp.enable_violation_events",
     security_csp_enable_violation_events,
    bool, true
  )