1432605 - WebExt alarms do not work between files (eg background.js and popup.js)

Status: VERIFIED FIXED

(WebExtensions :: Untriaged, defect)

Description

[fx4waldi]

Attachment: alarms.xpi

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180123102017

Steps to reproduce:

1. Create a new alarm in the background.js file, e.g.
browser.alarms.create("background",{periodInMinutes:0.1});

2. Create a new onAlarm event in background.js file e.g.
browser.alarms.onAlarm.addListener(alarm=>{console.log(alarm);});

3. Create a browserAction button with a popup.

4. Create a new alarm in the popup.js eg.
browser.alarms.create("popup",{periodInMinutes:0.1});

5. Install the extension.
6. Open the browser console (ctrl+shift+j)
7. Everything is fine, the log is displayed every 6 seconds.
8. Open the popup.
9. Alarms stop working.

Alternative STR:
1. Install the extension from attachment.
2. Open the browser console (ctrl+shift+j)
3. Everything is fine, the log is displayed every 6 seconds.
4. Open the popup and click the "Alarm" button.
5. Alarms stop working.

If I create an alarm via browser.runtime.sendMessage, the problem doesn't occur.
(Install the extension and click the "Message" on the popup)

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1432605: Fix alarms API when multiple contexts use it.

Review commit: https://reviewboard.mozilla.org/r/215108/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215108/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8944969 [details]
Bug 1432605: Fix alarms API when multiple contexts use it.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/215108/diff/1-2/

Comment 3

[Andrew Swan [:aswan]]

Comment on attachment 8944969 [details]
Bug 1432605: Fix alarms API when multiple contexts use it.

https://reviewboard.mozilla.org/r/215108/#review221004

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d22cc0f160121630d4a788d7c1fd8b8e88c4fbb0
Bug 1432605: Fix alarms API when multiple contexts use it. r=aswan

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d22cc0f16012

Comment 6

[marius.santa]

Attachment: alarm working.gif

I was able to reproduce the issue on Windows 10 64Bit Firefox 60.0a1 (20180122220231).
Tested and verified the issue in I was able to reproduce the issue on Windows 10 64Bit Firefox 60.0a1 (20180130102929).

Comment 7

[marius.santa]

Tested and verified on Windows 10 64Bit and Mac OS  X 10.13.2 in Firefox 60.0a1 (20180130102929).