1432643 - Prevent gn configs from multiple project overwriting one another

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Chris Manchester (limited bugmail, email directly)]

Sharing a single directory in the objdir for `gn gen` output simply doesn't work in the presence of multiple gn projects in the tree.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1432643 - Store `gn gen` output in the objdir per project.

Review commit: https://reviewboard.mozilla.org/r/215076/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215076/

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8944933 [details]
Bug 1432643 - Store `gn gen` output in the objdir per project.

https://reviewboard.mozilla.org/r/215076/#review221792

There are a ton of hits for `gn-output` in the tree.  Why doesn't https://searchfox.org/mozilla-central/search?q=gn-output&path= need to be updated?  (It kind of looks like $objdir was intended to be $topobjdir, so it's correct after your patch by being incorrect now.  Yay?)

There's a number of JSON files checked into the tree that must have been generated by dminor.  Do they need to be revved?  Should dminor review this?

If you're happy with these issues, r+ to avoid a re-review cycle.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8944933 [details]
Bug 1432643 - Store `gn gen` output in the objdir per project.

https://reviewboard.mozilla.org/r/215076/#review221792

I don't think the differences we end up causing in the JSON configs will be an issue. This is the destination for the generated JSON config, the paths aren't ending up in the generated moz.build files.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59ac85f05650
Store `gn gen` output in the objdir per project. r=nalexander

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/59ac85f05650