1432659 - Expose Pocket API to get your pocket stream

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Comment 1

[Ursula Sarracini (:ursula)]

Attachment: Bug 1432659 - Expose Pocket API to get your pocket stream

Review commit: https://reviewboard.mozilla.org/r/216358/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216358/

Comment 2

[Ursula Sarracini (:ursula)]

Comment on attachment 8946408 [details]
Bug 1432659 - Expose Pocket API to get your pocket stream

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/216358/diff/1-2/

Comment 3

[Ursula Sarracini (:ursula)]

Comment on attachment 8946408 [details]
Bug 1432659 - Expose Pocket API to get your pocket stream

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/216358/diff/2-3/

Comment 4

[Code Review Bot [:reviewbot]]

Comment on attachment 8946408 [details]
Bug 1432659 - Expose Pocket API to get your pocket stream

https://reviewboard.mozilla.org/r/216358/#review222146


Static analysis found 1 defect in this patch.
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint check path/to/file` (Python/Javascript/wpt)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: browser/extensions/pocket/content/pktApi.jsm:606
(Diff revision 2)
>      /**
> +     * Helper function to get a user's pocket stories
> +     * @return {Boolean} Returns Boolean whether the api call started sucessfully
> +     */
> +    function retrieve(data = {}, options = {}) {
> +        const data = Object.assign({}, data, {access_token: getAccessToken()});

Error: Parsing error: Identifier 'data' has already been declared [eslint: None]

Comment 5

[Ursula Sarracini (:ursula)]

Comment on attachment 8946408 [details]
Bug 1432659 - Expose Pocket API to get your pocket stream

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/216358/diff/3-4/

Comment 6

[Christian Sadilek [:csadilek]]

Comment on attachment 8946408 [details]
Bug 1432659 - Expose Pocket API to get your pocket stream

https://reviewboard.mozilla.org/r/216358/#review222150

Looks good to me!

Comment 7

[Code Review Bot [:reviewbot]]

Comment on attachment 8946408 [details]
Bug 1432659 - Expose Pocket API to get your pocket stream

https://reviewboard.mozilla.org/r/216358/#review222158


Static analysis found 1 defect in this patch.
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint check path/to/file` (Python/Javascript/wpt)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: browser/extensions/pocket/content/pktApi.jsm:606
(Diff revision 3)
>      /**
> +     * Helper function to get a user's pocket stories
> +     * @return {Boolean} Returns Boolean whether the api call started sucessfully
> +     */
> +    function retrieve(data = {}, options = {}) {
> +        const data = Object.assign({}, data, {access_token: getAccessToken()});

Error: Parsing error: Identifier 'data' has already been declared [eslint: None]

Comment 8

[Christian Sadilek [:csadilek]]

Comment on attachment 8946408 [details]
Bug 1432659 - Expose Pocket API to get your pocket stream

https://reviewboard.mozilla.org/r/216358/#review222172

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15f2562f1ba0
Expose Pocket API to get your pocket stream r=csadilek

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/15f2562f1ba0