Closed Bug 1432694 Opened 7 years ago Closed 7 years ago

Add a default value for the new upload-disabled pref

Categories

(Firefox :: Screenshots, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: jhirsch, Assigned: jhirsch)

Details

Attachments

(1 file)

When [1] lands, Firefox Screenshots will add a pref to allow users to use Screenshots in download-only mode (disallowing uploads to the Screenshots server). As we've done with the existing 'extensions.screenshots.disabled' pref, we should set a default value for the new 'extensions.screenshots.upload-disabled' pref, to help hint to users that such an option exists. [1] https://github.com/mozilla-services/screenshots/pull/4006
Comment on attachment 8945123 [details] Bug 1432694 - Add a default value for the Screenshots upload-disabled pref; https://reviewboard.mozilla.org/r/215354/#review222068 Assuming we want to change this in ESR I guess in the future we'll have an #ifdef around it. But that can follow later.
Attachment #8945123 - Flags: review?(ianb) → review+
Pushed by jhirsch@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b7429a85966 Add a default value for the Screenshots upload-disabled pref; r=ianbicking
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
The Feature request is implemented on Latest Nightly.. "extensions.screenshots.upload-disabled " is added in about:config . Fixing bug is verified on Latest Nightly-- Build ID :20180206100151 User Agent :Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Firefox/60.0 Tested OS-- Windows7 32bit
QA Whiteboard: [bugday-20180207]
The bug was about adding "extensions.screenshots.upload-disabled" pref in about:config and I have seen the feature being implemented with latest Nightly on Ubuntu 16.04 LTS! Build ID : 20180214224814 User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 [bugday-20180214]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: