Closed
Bug 1432811
Opened 8 years ago
Closed 8 years ago
Duplicative if defined clauses in GeckoChildProcessHost
Categories
(Core :: DOM: Content Processes, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: Alex_Gaynor, Assigned: Alex_Gaynor)
Details
Attachments
(1 file)
https://searchfox.org/mozilla-central/source/ipc/glue/GeckoChildProcessHost.cpp#841-1022
All the `defined(XP_WIN)` in this code are duplicative of the outer `if defined(OS_WIN)`.
Not a functional issue, just a slightly confusing structure to this code.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8945114 [details]
Bug 1432811 - remove duplicative #if clauses in process spawning;
https://reviewboard.mozilla.org/r/215338/#review220960
::: commit-message-0e62e:1
(Diff revision 1)
> +Bug 1432811 - remove duplicative if clauses in process spawning; r?bobowen
nit: s/if/#if/
Attachment #8945114 -
Flags: review?(bobowencode) → review+
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0530e041d7e6
remove duplicative #if clauses in process spawning; r=bobowen
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•