Closed Bug 1432857 Opened 7 years ago Closed 3 years ago

firefox-58.0/media/ffvpx/libavcodec/vp9block.c:471: obvious typo ?

Categories

(Core :: Audio/Video: Playback, defect, P3)

58 Branch
defect

Tracking

()

RESOLVED INACTIVE

People

(Reporter: dcb314, Unassigned, NeedInfo)

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0 Build ID: 20180118215408 Steps to reproduce: firefox-58.0/media/ffvpx/libavcodec/vp9block.c:471] -> [firefox-58.0/media/ffvpx/libavcodec/vp9block.c:472]: (warning) Opposite inner 'if' condition leads to a dead code block. Actual results: Source code is } else if (have_l && !td->left_intra_ctx[row7]) { if (td->left_intra_ctx[row7]) {
Component: Untriaged → Audio/Video
Product: Firefox → Core
Component: Audio/Video → Audio/Video: Playback
Does look like a typo, and it's still present upstream. Jean-Yves, do you mind getting this fixed with the ffmpeg people?
Flags: needinfo?(jyavenard)
Priority: -- → P3
Flags: needinfo?(jyavenard) → needinfo?(rbultje)
Chatted to Ronald over #ffmpeg-devel IRC a couple of weeks ago... hopefully they will fix it.
Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.