1432871 - about:telemetry isn't showing keyed histograms

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Chris H-C :chutten]

For some reason the "Keyed Histograms" category doesn't have the `has-data` class, so it is hidden on the left. But if you search for a keyed histogram (like SEARCH_COUNTS or FX_URLBAR_SELECTED_RESULT_INDEX_BY_TYPE) in the global "Find in all sections" search, you can find them.

If you open up the inspector and give it `has-data` you can then navigate as normal.

To fix: Find out why it isn't getting the has-data class even though it does, indeed, have data. Then fix that.

Comment 1

[Jeremy Lempereur [:o0ignition0o]]

Mind if I grab this one ? :)

Comment 2

[Chris H-C :chutten]

Please do. Let me know if you have any questions.

Comment 3

[Jeremy Lempereur [:o0ignition0o]]

http://ibb.co/cgDWim So on the left hand side is the version of Nightly I always use, and on the right hand side is the latest ./mach build && ./mach run.

Both have the "has-data" class on my setup, and I'm able to click on it and get the histograms. 

Are there any specific steps to reproduce it?

Meanwhile I'll dive into the code, to try to figure out if there anything that "triggers" the class add on my side and might not on yours.
Thanks :)

Comment 4

[Chris H-C :chutten]

Well whaddayaknow, it's working for me right now as well. :mkaply, do you still see this or have an idea of STR?

Comment 5

[Mike Kaply [:mkaply]]

Maybe it was fixed somehow? I see it on release with this STR:

Create new profile.
Search a few times in the URL bar.
Go to about:telemetry, no keyed histograms.
Close browser, restart, still no keyed histograms.

Search on SEARCH_COUNTS and you see the search counts.

Comment 6

[Jeremy Lempereur [:o0ignition0o]]

Hi Mike :)

I've just reproduced it with a new profile (on stable), this is the key I guess, thanks for your input !

Comment 7

[Jeremy Lempereur [:o0ignition0o]]

Well It seems like I can't reproduce it on nightly, chutten can you confirm this? 

If so we can mark it as worksforme :)

Comment 8

[Chris H-C :chutten]

Seems to be working with a fresh profile on latest Nightly. Steps I tried

1) Load Nightly (2018-01-30 x64) with a fresh profile
2) Perform a urlbar search
3) Open about:telemetry

keyed histograms are present as a category and with actual values. I shut down and restarted the browser just to see if keyed histograms would show up. And they did.

I wonder if it has to do with fewer keyed histograms being recorded in release. Jeremy, could you try simulating this by building with MOZ_UPDATE_CHANNEL=release in your mozconfig, and then running through the STR?

Comment 9

[Jeremy Lempereur [:o0ignition0o]]

I just built with MOZ_UPDATE_CHANNEL=release in my mozconfig, and reproduced your steps.

This still looks fine to me : http://ibb.co/nbeWJm

Comment 10

[Chris H-C :chutten]

Hm, somehow it didn't work to correctly limit the histograms that are recorded. NETWORK_HTTP_REDIRECT_TO_SCHEME is not supposed to be recorded on non-prerelease channels.

Maybe build without MOZ_UPDATE_CHANNEL and use MOZ_OFFICIAL=true instead. We're looking for a build that makes toolkit.telemetry.enabled (in about:config) read as false.

Comment 11

[Jeremy Lempereur [:o0ignition0o]]

Ok I'll check it out asap, 
By the way I'm looking for resources on which flags I can enable / disable on my builds, but I can't find any list, only found https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Configuring_Build_Options. 
Am I missing some documentation somewhere ? :)

Comment 12

[Mike Kaply [:mkaply]]

I usually just go to about:buildconfig to find that answer

--enable-update-channel=release
MOZILLA_OFFICIAL=1
 --enable-official-branding

I think those are the main ones.

Comment 13

[Jeremy Lempereur [:o0ignition0o]]

Thanks for the tip (and for the about:buildconfig link which I didn't know...About ;) )
I'm recompiling with theese flags, and I'll give it an other try !

Comment 14

[Jeremy Lempereur [:o0ignition0o]]

I've been able to reproduce the bug with the flags you mentioned : http://ibb.co/ig4fDm I'm on it ! :)

Comment 15

[Jeremy Lempereur [:o0ignition0o]]

Attachment: Bug 1432871 - about:telemetry - showing the Keyed Histograms category.

The "Keyed Histograms" category didn't alway have the "has-data" class although there were some data to display. "option" was compared to a string but it's a dom element, so its value should be compared instead.

Review commit: https://reviewboard.mozilla.org/r/216350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216350/

Comment 16

[Jeremy Lempereur [:o0ignition0o]]

There should be the same bug here AFAIU https://dxr.mozilla.org/mozilla-central/source/toolkit/content/aboutTelemetry.js#2222

I'll try to reproduce it and file a followup bug if I'm correct !

Comment 17

[Chris H-C :chutten]

It certainly seems to have the same pattern. You can fix it in this same bug.

Comment 18

[Chris H-C :chutten]

Comment on attachment 8947066 [details]
Bug 1432871 - about:telemetry - showing the Keyed Histograms category.

https://reviewboard.mozilla.org/r/216350/#review222690

Ah-ha! So it would work so long as there were keyed histograms recorded in any child processes. We'd eventually loop to "content" or "gpu" or something in the keyedHgramsSelect's options, and there'd be some data in that part.

But in release, we collect fewer histograms, so it would be more likely that there weren't keyedhistograms in any child process.

Your follow-up will likely not have a reproducible case unless you can construct a case when histograms are only recorded in the parent process (maybe non-e10s mode or something). Still worth fixing. Good catch!

Comment 19

[Jeremy Lempereur [:o0ignition0o]]

Great \o/ Glad I caught this ! I'll write a followup patch and attach it to this review request then :)

Comment 20

[Jeremy Lempereur [:o0ignition0o]]

Attachment: Bug 1432871 - about:telemetry - Fix selected option comparison in the Histograms section

Followup on the previous commit, the same pattern occured in the Histograms section.

Review commit: https://reviewboard.mozilla.org/r/216884/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216884/

Comment 21

[Chris H-C :chutten]

Comment on attachment 8947086 [details]
Bug 1432871 - about:telemetry - Fix selected option comparison in the Histograms section

https://reviewboard.mozilla.org/r/216884/#review222700

Looks good! With these fixes, does the problem resolve? We can get keyedhistograms showing on your faux-release build?

Comment 22

[Jeremy Lempereur [:o0ignition0o]]

Comment on attachment 8947086 [details]
Bug 1432871 - about:telemetry - Fix selected option comparison in the Histograms section

https://reviewboard.mozilla.org/r/216884/#review222700

http://ibb.co/i5YFUR I think it looks good :)

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0870eec86b90
about:telemetry - showing the Keyed Histograms category. r=chutten
https://hg.mozilla.org/integration/autoland/rev/0785f42ebff6
about:telemetry - Fix selected option comparison in the Histograms section r=chutten

Comment 24

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/0870eec86b90
https://hg.mozilla.org/mozilla-central/rev/0785f42ebff6