Closed
Bug 1432872
Opened 7 years ago
Closed 7 years ago
Do not run test-verify on beta
Categories
(Testing :: General, enhancement)
Testing
General
Tracking
(firefox59 fixed, firefox60 fixed)
RESOLVED
FIXED
mozilla60
People
(Reporter: gbrown, Assigned: gbrown)
References
Details
Attachments
(1 file)
1.44 KB,
patch
|
RyanVM
:
review+
|
Details | Diff | Splinter Review |
As raised in bug 1431154: Some test types (screenshots) don't normally run on beta, so it seems wrong to verify such tests on beta. Also, when we promote changes to beta quickly, a single verification failure may repeat on multiple branches, triggering stockwell triage with minimal value.
Let's skip test-verify outside of [inbound/autoland/central].
![]() |
Assignee | |
Comment 1•7 years ago
|
||
Does that seem reasonable?
Attachment #8945182 -
Flags: review?(ryanvm)
Comment 2•7 years ago
|
||
Comment on attachment 8945182 [details] [diff] [review]
run test-verify only on central, inbound, autoland, and try
Review of attachment 8945182 [details] [diff] [review]:
-----------------------------------------------------------------
::: taskcluster/ci/test/misc.yml
@@ +70,5 @@
> by-test-platform:
> # do not run on ccov; see also the enable_code_coverage transform
> linux64-ccov/.*: []
> + # do not run on beta or release: usually just confirms earlier results
> + default: ['mozilla-central', 'autoland', 'mozilla-inbound', 'try']
Couldn't this be ['trunk', 'try'] instead? Anyway, I'm fine in principle with this change.
::: taskcluster/ci/test/web-platform.yml
@@ +137,5 @@
> by-test-platform:
> # do not run on ccov; see also the enable_code_coverage transform
> linux64-ccov/.*: []
> + # do not run on beta or release: usually just confirms earlier results
> + default: ['mozilla-central', 'autoland', 'mozilla-inbound', 'try']
Likewise.
Attachment #8945182 -
Flags: review?(ryanvm) → review+
![]() |
Assignee | |
Comment 3•7 years ago
|
||
Thanks! Will change to 'trunk'...
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95cfbed0308f
Stop running test-verify on beta and release; r=ryanvm
Comment 5•7 years ago
|
||
bugherder uplift |
status-firefox59:
--- → fixed
Comment 6•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•