1432890 - Refactor the Policies JSON code out of the Policies Manager object in order to support other policies sources (e.g. GPO)

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, enhancement)

Description

[:Felipe Gomes (needinfo for replies!)]

Refactor the Policies JSON code out of the Policies Manager object in order to support other policies sources. This is in advance of the work to be done (in another bug) to support GPO.

Goals:
- Make it easier to implement newer sources of policies in a well-defined order
- Each source should provide the final activePolicies object, which will be stored by the policy manager (it will store it in order to display the list of policies in about:policies or about:support)
- Load as little code as necessary when that source of policies is not being used

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1432890 - Refactor the Policies JSON code out of the Policies Manager object in order to support other policies sources.

Review commit: https://reviewboard.mozilla.org/r/216316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216316/

Comment 2

[:Felipe Gomes (needinfo for replies!)]

(no reviewer yet because I'm not sure if I'll make more changes to this)

Comment 3

[:Felipe Gomes (needinfo for replies!)]

This was just a small refactoring to move the file reading code to a separate object. This object should be a class that implements two public methods

class PoliciesProvider {
  bool hasPolicies();
  jsval getPolicies();
}

The existing code was called the JSONPoliciesProvider, and the GPOPoliciesProvider will be implemented in bug 1433136

Comment 4

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Comment on attachment 8946352 [details]
Bug 1432890 - Refactor the Policies JSON code out of the Policies Manager object in order to support other policies sources.

https://reviewboard.mozilla.org/r/216316/#review223774

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee868e1ec636
Refactor the Policies JSON code out of the Policies Manager object in order to support other policies sources. r=Mossop

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c48084ca4348
Backed out 2 changesets (bug 1432890, bug 1429162) for failing in dom/canvas/test/webgl-conf/generated/ on a CLOSED TREE

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fe2cd2df9ed
Refactor the Policies JSON code out of the Policies Manager object in order to support other policies sources. r=Mossop

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/5fe2cd2df9ed