Closed Bug 1432890 Opened 4 years ago Closed 4 years ago

Refactor the Policies JSON code out of the Policies Manager object in order to support other policies sources (e.g. GPO)

Categories

(Firefox :: Enterprise Policies, enhancement)

60 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: Felipe, Assigned: Felipe)

References

Details

Attachments

(1 file)

Refactor the Policies JSON code out of the Policies Manager object in order to support other policies sources. This is in advance of the work to be done (in another bug) to support GPO.

Goals:
- Make it easier to implement newer sources of policies in a well-defined order
- Each source should provide the final activePolicies object, which will be stored by the policy manager (it will store it in order to display the list of policies in about:policies or about:support)
- Load as little code as necessary when that source of policies is not being used
Blocks: 1433136
Blocks: 1433173
(no reviewer yet because I'm not sure if I'll make more changes to this)
Attachment #8946352 - Flags: review?(dtownsend)
This was just a small refactoring to move the file reading code to a separate object. This object should be a class that implements two public methods

class PoliciesProvider {
  bool hasPolicies();
  jsval getPolicies();
}

The existing code was called the JSONPoliciesProvider, and the GPOPoliciesProvider will be implemented in bug 1433136
Comment on attachment 8946352 [details]
Bug 1432890 - Refactor the Policies JSON code out of the Policies Manager object in order to support other policies sources.

https://reviewboard.mozilla.org/r/216316/#review223774
Attachment #8946352 - Flags: review?(dtownsend) → review+
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee868e1ec636
Refactor the Policies JSON code out of the Policies Manager object in order to support other policies sources. r=Mossop
Backout by nerli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c48084ca4348
Backed out 2 changesets (bug 1432890, bug 1429162) for failing in dom/canvas/test/webgl-conf/generated/ on a CLOSED TREE
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fe2cd2df9ed
Refactor the Policies JSON code out of the Policies Manager object in order to support other policies sources. r=Mossop
https://hg.mozilla.org/mozilla-central/rev/5fe2cd2df9ed
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.