1432907 - Add build flag to disable network tickler

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Arthur Edelstein [:arthur]]

In Tor Browser, a patch disables the network tickler. We would like to propose adding a build flag in Firefox that disables the network tickler, so we can add it to Tor Browser's mozconfig.

The existing patch is at
https://torpat.ch/18799
The original ticket as at
https://trac.torproject.org/18799

Comment 1

[Gregory Szorc [:gps]]

Since it touches C++, over to the Necko module.

This doesn't seem too bad from the build system side. If you need help with the patch, ping a build peer.

Comment 2

[Honza Bambas (:mayhemer)]

I think this is more about changes to our build scripts.

Comment 3

[(not currently active) Ted Mielczarek]

The simplest thing to do here would be something like (probably in toolkit/moz.configure):
```
@depends(target)
def wifi_tickler_default(target):
    return target.os == 'Android'

@option('--disable-wifi-tickler', default=wifi_tickler_default, help='Disable WiFi tickler, which is used on mobile to mitigate Power Save Polling mode')

@depends('--disable-wifi-tickler')
def wifi_tickler(value):
  if value:
     return True

set_define('MOZ_USE_WIFI_TICKLER', wifi_tickler)
```
Then simply remove the `#if defined(ANDROID) ...` bits from Tickler.h.

Comment 4

[Arthur Edelstein [:arthur]]

Attachment: 0001-Bug-1432907-Disable-network-tickler-with-proxy-bypas.patch

Here's an approach that uses the --enable-proxy-bypass-protection flag.

Comment 5

[Arthur Edelstein [:arthur]]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/84075ce9cbe8
Disable network tickler with proxy bypass protection r=mayhemer

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/84075ce9cbe8