1432915 - Do not write the kMDItemWhereFroms xattr metadata for files downloaded in Private Browsing mode

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect, P1)

Description

[(no longer active)]

This is related to bug 1374027.  In PB mode, we definitely should stop writing this xattr to disk when downloading files, whether or not we add an about:config flag to control the behavior outside of PB mode.

Comment 1

[Luke Crouch [:groovecoder]]

Marking this P1 and assigning to myself. I have a 1-line fix patch ready already, but I could use some advice if (and where) we can write the Mac-specific test for this.

Comment 2

[Luke Crouch [:groovecoder]]

Attachment: Bug 1432915 - don't save download source url when aIsPrivate

Review commit: https://reviewboard.mozilla.org/r/216676/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216676/

Comment 3

[(no longer active)]

Comment on attachment 8946703 [details]
Bug 1432915 - don't save download source url when aIsPrivate

https://reviewboard.mozilla.org/r/216676/#review222514

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91c18ad31b29
don't save download source url when aIsPrivate r=Ehsan

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/91c18ad31b29

Comment 6

[Luke Crouch [:groovecoder]]

Comment on attachment 8946703 [details]
Bug 1432915 - don't save download source url when aIsPrivate

Approval Request Comment
[Feature/Bug causing the regression]:
https://bugzilla.mozilla.org/show_bug.cgi?id=337051

[User impact if declined]:
Mac users' private browsing history leaks to disk when they download a file in private browsing; esp. bad for users of "Always use Private Browsing"

[Is this code covered by automated tests?]:
no

[Has the fix been verified in Nightly?]:
yes

[Needs manual test from QE? If yes, steps to reproduce]: 
(On Mac OS)
Open Private Browsing
Download a file in the private browsing window
Right-click the downloaded file, choose "Get Info" from the context menu
Expected results: There should be no "Where From" value in the info


[List of other uplifts needed for the feature/fix]:
none

[Is the change risky?]:
no

[Why is the change risky/not risky?]:
1-line variable check change

[String changes made/needed]:
none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8946703 [details]
Bug 1432915 - don't save download source url when aIsPrivate

One-liner privacy fix. Taking for 59b8.

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a40559a7c596

Comment 9

[roxleitan]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID:2018020818154

Reproduced the issue on Nightly (2018-01-24) using the STR from comment 6.

Verified fixed using Nightly 60.0a1 (2018-02-09) and Firefox Beta 59.0b8 on Mac OS X 10.12.