1432928 - Use mutator in extensions.xml::refreshInfo

Status: RESOLVED FIXED

(Core :: Networking, enhancement)

Description

[Valentin Gosu [:valentin] {{ PTO 2 - 12 April }}]

My patches in bug 1432187 missed this one.

https://searchfox.org/mozilla-central/rev/4611b9541894e90a421debb57ddbbcff55c2f369/toolkit/mozapps/extensions/content/extensions.xml#1933

Comment 1

[Valentin Gosu [:valentin] {{ PTO 2 - 12 April }}]

Attachment: Bug 1432928 - Use nsIURIMutator in extensions.xml::refreshInfo

Review commit: https://reviewboard.mozilla.org/r/215622/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215622/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8945471 [details]
Bug 1432928 - Use nsIURIMutator in extensions.xml::refreshInfo

https://reviewboard.mozilla.org/r/215622/#review222508

::: toolkit/mozapps/extensions/content/extensions.xml:1935
(Diff revision 1)
>              if (this.mInstall.name) {
>                this._name.value = this.mInstall.name;
>              } else if (this.mInstall.sourceURI) {
> -              var url = Components.classes["@mozilla.org/network/standard-url;1"]
> -                                  .createInstance(Components.interfaces.nsIStandardURL);
> -              url.init(url.URLTYPE_STANDARD, 80, this.mInstall.sourceURI.spec,
> +              var url = Components.classes["@mozilla.org/network/standard-url-mutator;1"]
> +                                  .createInstance(Components.interfaces.nsIStandardURLMutator)
> +                                  .init(url.URLTYPE_STANDARD, 80,

I wouldn't expect url to be assigned at this point so I suspect that this is failing. Is this passing tests?

Comment 3

[Valentin Gosu [:valentin] {{ PTO 2 - 12 April }}]

Comment on attachment 8945471 [details]
Bug 1432928 - Use nsIURIMutator in extensions.xml::refreshInfo

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/215622/diff/1-2/

Comment 4

[Valentin Gosu [:valentin] {{ PTO 2 - 12 April }}]

(In reply to Dave Townsend [:mossop] from comment #2)
> Comment on attachment 8945471 [details]
> > +                                  .createInstance(Components.interfaces.nsIStandardURLMutator)
> > +                                  .init(url.URLTYPE_STANDARD, 80,
> 
> I wouldn't expect url to be assigned at this point so I suspect that this is
> failing. Is this passing tests?

You're completely right. The code was faulty.
However, it didn't fail any tests. I assume this code is lacking code coverage, or the error was silently ignored.

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8945471 [details]
Bug 1432928 - Use nsIURIMutator in extensions.xml::refreshInfo

https://reviewboard.mozilla.org/r/215622/#review222836

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0936ba31843e
Use nsIURIMutator in extensions.xml::refreshInfo r=mossop

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0936ba31843e