Rust SDP Parser fails to produce an error on NewSdpTest.ParseInvalidSimulcastNotSending

RESOLVED FIXED in Firefox 62

Status

()

defect
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dminor, Assigned: johannes.willbold)

Tracking

(Blocks 1 bug)

58 Branch
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

a year ago
[ RUN      ] RoundTripSerialize/NewSdpTest.ParseInvalidSimulcastNotSending/0
version: 0
origin: -, 4294967296, 2, 127.0.0.1
session: SIP Call
connection: 198.51.100.7
bandwidth: CT, 5000
timing: 0, 0
media: Video, 56436, Rtp/Savpf, [120]
/home/dminor/src/firefox/media/webrtc/signaling/gtest/sdp_unittests.cpp:3783: Failure
Expected: ("") != (GetParseErrors()), actual: "" vs ""
[  FAILED  ] RoundTripSerialize/NewSdpTest.ParseInvalidSimulcastNotSending/0, where GetParam() = (false, false) (1 ms)
Assignee: nobody → johannes.willbold
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8983214 [details]
Bug 1432934: Added sanity check for recvonly attribute.

https://reviewboard.mozilla.org/r/249064/#review255536
Attachment #8983214 - Flags: review?(docfaraday) → review+

Comment 3

a year ago
mozreview-review
Comment on attachment 8983214 [details]
Bug 1432934: Added sanity check for recvonly attribute.

https://reviewboard.mozilla.org/r/249064/#review256646

I think this needs a little fix in the error message before we land it.

::: media/webrtc/signaling/src/sdp/rsdparsa/src/lib.rs:623
(Diff revision 1)
>          }
> +        if msection.get_attribute(SdpAttributeType::Recvonly).is_some() {
> +            if let Some(&SdpAttribute::Simulcast(ref x)) = msection.get_attribute(SdpAttributeType::Simulcast) {
> +                if x.send.len() > 0 {
> +                    return Err(SdpParserError::Sequence {
> +                        message: "Simulcast can't define send parameters for recvonly".to_string(),

Why does this have the same error message as the check above?
Assignee

Comment 4

a year ago
mozreview-review-reply
Comment on attachment 8983214 [details]
Bug 1432934: Added sanity check for recvonly attribute.

https://reviewboard.mozilla.org/r/249064/#review256646

> Why does this have the same error message as the check above?

This error message is correct, the above is incorrect and has already been fixed in another commit.

Comment 5

a year ago
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/a3a7ac1e38f6
Added sanity check for recvonly attribute. r=bwc

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a3a7ac1e38f6
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.