1432983 - Introduce a build flag to disable libmdns

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Arthur Edelstein [:arthur]]

In Tor Browser, as a defense in depth, we disable libmdns. Here is the current patch:
https://torpat.ch/18821
and here is the ticket:
https://trac.torproject.org/18821

We would like to propose uplifting this build behavior, behind a build flag such as --disable-mdns

Comment 1

[Mike Hommey [:glandium]]

If we're going to add a flag for each individual thing you're disabling for defense in depth against proxy bypass, we're going to have a lot of, mostly useless, configure flags. Wouldn't it be better if you gated everything behind a single flag? (it would even be better for you, because you wouldn't have to add all these to your mozconfig)

Comment 2

[Arthur Edelstein [:arthur]]

(In reply to Mike Hommey [:glandium] from comment #1)
> If we're going to add a flag for each individual thing you're disabling for
> defense in depth against proxy bypass, we're going to have a lot of, mostly
> useless, configure flags. Wouldn't it be better if you gated everything
> behind a single flag? (it would even be better for you, because you wouldn't
> have to add all these to your mozconfig)

Great idea. I created a meta bug, "ProxyBypass".

Comment 3

[Makoto Kato [:m_kato]]

I think that no one uses libmdns since we removed Presentation API and video casting of second screen.

Comment 4

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

searchfox does seem to show no references; I've sent in a try run and will give it a shot. https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e46a279d007e4795e532063e29951bd05019b90

Comment 5

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1432983 - Remove mdns r?dragana

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d090400a5d3
Remove mdns r=necko-reviewers,kershaw

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2d090400a5d3