1432994 - When dom.indexedDB.enabled is false, browser console reports InvalidStateErrors on opening

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P5)

Description

[Arthur Edelstein [:arthur]]

We observed this in Tor Browser, and wrote the following workaround patch:
https://torpat.ch/18619
Here's the original ticket.
https://trac.torproject.org/18619

Perhaps better patch would allow indexeddb to work in the browser console regardless of the pref value. Setting dom.indexedDB.enabled to false is supposed to only disable indexeddb for content (see bug 1079355).

Comment 1

[Brian Grinstead [:bgrins]]

(In reply to Arthur Edelstein (Tor Browser dev) [:arthuredelstein] from comment #0)
> Perhaps better patch would allow indexeddb to work in the browser console
> regardless of the pref value. Setting dom.indexedDB.enabled to false is
> supposed to only disable indexeddb for content (see bug 1079355).

Huh, based on the description of Bug 1079355 I would expect it to not be disabled for the Browser Console. But I do see 'uncaught exception: undefined' during Browser Console startup and each time when executing code in the input with dom.indexedDB.enabled=false.

Comment 2

[Brian Grinstead [:bgrins]]

Reading https://trac.torproject.org/projects/tor/ticket/18619#comment:12 it looks like a fix here isn't needed for Tor Browser anymore. Still, I would expect indexeddb to work in the browser chrome regardless of the pref value.

Comment 3

[:Gijs (he/him)]

Are we sure this only affects the browser console, ie maybe bug 1079355 just regressed, also for other chrome consumers? Has the code changed in the last few years? (not entirely outside of the realm of possibility considering the timeframe!) Is the code run in the browser console actually run inside something that has system principal, or does it have some funky other kind of principal (sandbox that's built on top of something else or whatever) ?

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to :Gijs from comment #3)
> Are we sure this only affects the browser console, ie maybe bug 1079355 just
> regressed, also for other chrome consumers? Has the code changed in the last
> few years? (not entirely outside of the realm of possibility considering the
> timeframe!) Is the code run in the browser console actually run inside
> something that has system principal, or does it have some funky other kind
> of principal (sandbox that's built on top of something else or whatever) ?

I'm not sure - but I suspect that it's broken for other chrome consumers as well since the webconsole access is pretty simple (https://searchfox.org/mozilla-central/source/devtools/shared/async-storage.js).

Comment 5

[Gregory Pappas [:gregp]]

All dependencies are fixed; closing.