1433080 - No longer show the template for tracking & release notes requests

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

In the past, when selecting the tracking request "?", we used to have a template which would tell the user to explain why.

I don't see it anymore.
For example, I tried on this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1433065

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Ditto for the release notes "relnote-firefox" flag.
Saw that here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1409973#c40

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Attachment: Screen Shot 2018-03-02 at 11.05.07.png

Is the template this comment stuff?

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Attachment: Screen Shot 2018-03-02 at 11.07.41.png

I see "comment required", a link which produces the template, here (screenshot attached) though I had to change it to ? first.

Is this it or was it something else?

Comment 4

[Dylan Hardison [:dylan] (he/him)]

After we confirm what this is -- kohei, do you have any bandwidth to see if this changed?

Comment 5

[Sylvestre Ledru [:Sylvestre]]

yes, I confirm this but to be clear, the tracking request is really what matters :)

Comment 6

[Dylan Hardison [:dylan] (he/him)]

So I think tracking_flag_change() isn't getting called now,
or at the very least it isn't making it to this part of code:

https://github.com/mozilla-bteam/bmo/blob/master/extensions/TrackingFlags/web/js/tracking_flags.js#L75-L89

Comment 7

[Dylan Hardison [:dylan] (he/him)]

So when I set breakpoints in the js, and change the selector to ?, I get text filled in.

https://screenshots.firefox.com/Z8rTT6xlk8idghWG/bugzilla.mozilla.org

Comment 8

[Dylan Hardison [:dylan] (he/him)]

but if I do not set breakpoints, nothing happens.

Comment 9

[Dylan Hardison [:dylan] (he/him)]

After using the debugger, I can't reproduce this. Even if I restart the browser.
What happened?

Comment 10

[Dylan Hardison [:dylan] (he/him)]

Attachment: PR

Need to work on the .htaccess rewrite rule but this should prevent this from bothering other people.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Dylan, I am still experiencing this issue with ublock origin

Comment 12

[Dylan Hardison [:dylan] (he/him)]

I'll see about getting this landed then.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Sorry to be a pain about that but do you have an eta for this?
thanks

Comment 14

[Dylan Hardison [:dylan] (he/him)]

Renaming tracking flags is a real pain at the moment, I'm hoping some other work will make doing this easier.
My first naive attempt didn't work.

I recommend not using ublock origin for bmo since bmo doesn't show ads in the meantime.

Comment 15

[Kohei Yoshino]

So we have nothing to do here? I have enabled Tracking Protection by default in my Firefox but everything looks fine. These comment templates could be converted to temporary forms just like Bug 1489718 but it’s a separate issue.

Comment 16

[Sylvestre Ledru [:Sylvestre]]

We should just rename the script to avoid ublock blocking it.

Comment 17

[Kohei Yoshino]

This is on my radar.

Comment 18

[Kohei Yoshino]

Attachment: GitHub Pull Request

The culprit was the JavaScript file name tracking_flags.js, so simply renaming it will solve the issue. Looks like the directory name TrackingFlags is not a problem.

Comment 19

[Kohei Yoshino]

Merged to master.