Closed
Bug 1433101
Opened 6 years ago
Closed 6 years ago
Add a pref to control whether or how dispatch keypress event from TextEventDispatcher
Categories
(Core :: Widget, enhancement)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(2 files)
Before working on bug 968056, we need to know we need to change how much keyboard event listeners. So, we should add a new pref into TextEventDispatcher.
Assignee | ||
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d585b4df9731946328c5dae6553f03bc1d31398
Assignee | ||
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=983fe01ef82eef8ffcae722d8962b2f54af88419
Assignee | ||
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c15fdbff6eb1beeb7880259f5309e4e90cecde63
Assignee | ||
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fc696ae1e5be247282aad1252507a7b0199f2f8
Assignee | ||
Comment 5•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=68693242c1e6b142dec1b0ee57c126c499ee4fde
Assignee | ||
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b68ea1f8583774e64c54f9cea086ed06ff7b399
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 9•6 years ago
|
||
I was thinking that followup fixes mainly for automated tests should be reviewed by stone. However, as far as I know, he is not available now. So, I'm currently thinking that smaug needs to review them even though I know you're really busy. If you know some people who should review them, let me know. Or, I'm a co-module owner of Event Handling, so, just fixing existing event handler may be able to reviewed by anybody?
Comment 10•6 years ago
|
||
Happy to review
Comment 11•6 years ago
|
||
mozreview-review |
Comment on attachment 8945668 [details] Bug 1433101 - part 1: Add new pref which disables keypress event for non-printable keys only for the default event group in web content https://reviewboard.mozilla.org/r/215800/#review221634
Attachment #8945668 -
Flags: review?(bugs) → review+
Comment 12•6 years ago
|
||
mozreview-review |
Comment on attachment 8945669 [details] Bug 1433101 - part 2: Treat Enter and Shift+Enter as printable key https://reviewboard.mozilla.org/r/215802/#review221640
Attachment #8945669 -
Flags: review?(bugs) → review+
Comment 13•6 years ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/81157078b090 part 1: Add new pref which disables keypress event for non-printable keys only for the default event group in web content r=smaug https://hg.mozilla.org/integration/autoland/rev/34abf9793163 part 2: Treat Enter and Shift+Enter as printable key r=smaug
Comment 14•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/81157078b090 https://hg.mozilla.org/mozilla-central/rev/34abf9793163
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•