Closed Bug 1433101 Opened 2 years ago Closed 2 years ago

Add a pref to control whether or how dispatch keypress event from TextEventDispatcher

Categories

(Core :: Widget, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(2 files)

Before working on bug 968056, we need to know we need to change how much keyboard event listeners. So, we should add a new pref into TextEventDispatcher.
I was thinking that followup fixes mainly for automated tests should be reviewed by stone. However, as far as I know, he is not available now. So, I'm currently thinking that smaug needs to review them even though I know you're really busy. If you know some people who should review them, let me know.  Or, I'm a co-module owner of Event Handling, so, just fixing existing event handler may be able to reviewed by anybody?
Happy to review
Depends on: 1433413
Comment on attachment 8945668 [details]
Bug 1433101 - part 1: Add new pref which disables keypress event for non-printable keys only for the default event group in web content

https://reviewboard.mozilla.org/r/215800/#review221634
Attachment #8945668 - Flags: review?(bugs) → review+
Comment on attachment 8945669 [details]
Bug 1433101 - part 2: Treat Enter and Shift+Enter as printable key

https://reviewboard.mozilla.org/r/215802/#review221640
Attachment #8945669 - Flags: review?(bugs) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/81157078b090
part 1: Add new pref which disables keypress event for non-printable keys only for the default event group in web content r=smaug
https://hg.mozilla.org/integration/autoland/rev/34abf9793163
part 2: Treat Enter and Shift+Enter as printable key r=smaug
https://hg.mozilla.org/mozilla-central/rev/81157078b090
https://hg.mozilla.org/mozilla-central/rev/34abf9793163
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.