1433146 - add support for lists of distributions

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P1)

Description

[[e-mail] (:bhearsum)]

In bug 1430254 we've been asked to remove distribution/ for a large number of partner repacks. In order to accommodate this without one rule per distribution we need to add support for lists of distributions, and widen the field. I'm going to suggest 2000 characters, which allows for ~175 "mozillaNN' distributions to be specified in one rule (we have at least 119 funnelcakes that we intend to apply this to, plus non-funnelcake partner distributions).

We should fix bug 1432044 for this too -- otherwise distribution lists will overflow in the UI.

Comment 1

[Allan [:asilva]]

:bhearsum, can the new "distribution" field model, conflicts with the "distVersion" field?
Seems that both fields are highly related.

If so, I think we can't separate "distVersion" by comma too. Consider the following:

Ubuntu/1.17
Ubuntu/1.16
Mint/1.16

Update request for Mint/1.17 can serve the wrong update.

Maybe I missed something...

Comment 2

[[e-mail] (:bhearsum)]

(In reply to Allan [:asilva] from comment #1)
> :bhearsum, can the new "distribution" field model, conflicts with the
> "distVersion" field?
> Seems that both fields are highly related.
> 
> If so, I think we can't separate "distVersion" by comma too. Consider the
> following:
> 
> Ubuntu/1.17
> Ubuntu/1.16
> Mint/1.16
> 
> Update request for Mint/1.17 can serve the wrong update.
> 
> Maybe I missed something...

They're definitely related, but they're nothing to do with OS -- they related to our "distribution" system that allows us to customize Firefox builds for different reasons. For example, we do some called "Funnelcakes", that we use for different A/B testing. These have "distribution" set to something like "mozilla88" (where the number at the end increasing for each different A/B test), and "distVersion" is set to "1.0". We end up with an URL like: https://aus5.mozilla.org:443/update/3/GMP/53.0.3/20170518000419/WINNT_x86-msvc-x64/en-US/release-cck-mozilla88/Windows_NT%2010.0.0.0%20(x64)/mozilla88/1.0/update.xml

With that said, it's a good point that distribution and distVersion are linked. We wouldn't want to set Rules that have list of distributions and also set a distVersion - it would almost never make sense to. It could make sense to use a single distribution and a list of distVersions, or a list of distributions with a null distVersion, however. The latter is what we're looking for here - as bug 1430254 only needs us to match on the "distribution" field.

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/22ada17e60c9eb68c33e6d98d5ca472b45adc91b
bug 1433146: add support for lists of distributions (#467). r=bhearsum

Comment 4

[[e-mail] (:bhearsum)]

In production - thanks Allan!