143316 - Mac: keyboad events not working with all full-page plugins

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[shrirang khanzode]

mac only, 0509 branch build.

go to the url.

try to type in the textbox...click on submit.
nothing happens. :(

Comment 1

[shrirang khanzode]

peterl..

Comment 2

[Peter Lubczynski]

...one line fix on the way, testing in Carbon now...

Comment 3

[Peter Lubczynski]

Attachment: 1-line patch

This apprently looks like it was caused by bug 84681. This patch removes one of
the hacked lines inserted from that bug.

Comment 4

[av (gone)]

Does not it regress back to that bug now?

Comment 5

[Peter Lubczynski]

oddly, no! I tested and it and works in both Classic/Carbon. 

That's an old bug and our event system keeps playing tricks on me.

Comment 6

[rubydoo123]

adding ADT marker and milestone

Comment 7

[scottputterman]

Please get a review and super review for this.

Comment 8

[Jaime Rodriguez, Jr.]

Removing adt1.0.0, because the patch does not have r/sr=. Pls get the reviews,
and land this on the trunk, then add adt1.0.0 keyword.

Comment 9

[Peter Lubczynski]

Attachment: full-page flash text box testcase

Comment 10

[Peter Lubczynski]

This bug has become more serious. It seems QT and Flash are both effected -- no
keyboard events are working on any full-page plugins on Mac.

This does not regress bug 84681. All full-page plugins on Mac are working
correctly after this patch and this patch is in a #ifdef XP_MAC section.

Comment 11

[av (gone)]

Comment on attachment 82977 [details] [diff] [review]
1-line patch

Fine with me. Peter also conducted massive testing with other plugins focussing
on key input. r=av

Comment 12

[Marc Attinasi]

Comment on attachment 82977 [details] [diff] [review]
1-line patch

sr=attinasi - it would be nice to know why this stopped working though ;-)

Comment 13

[Peter Lubczynski]

Full-page plugins are very sensitve to event changes because they live at the
document viewer level. In one of the many changes to events in the past year,
plugin code is no longer incorrectly recieving double key events (wallpapered by
bug 84681) but now correctly recieving single events.

The code around this is still pretty messy so I've opened bug 144876 to clean up.

Comment 14

[Peter Lubczynski]

patch on trunk, marking FIXED.

Comment 15

[rubydoo123]

testing on OSX with the trunk build from 2002051608 functions correctly with the
attached test case from comment #9

Comment 16

[Peter Lubczynski]

Quicktime testcase:
http://starwars.apple.com/ep2/breathing/img/sw_ctp_240.mov
Without the patch, the space bar does not start/stop the movie.

Also note that there is no Acrobat 5 for Carbon.

Comment 17

[scottputterman]

adding adt1.0.0+.  Please get drivers approval and then check into the 1.0 branch.

Comment 18

[Dawn Endico]

Comment on attachment 82977 [details] [diff] [review]
1-line patch

a=chofmann,brendan,etc

need to check this in asap for rc3. -thanks

Comment 19

[Peter Lubczynski]

patch on branch

thanks everyone!

Comment 20

[shrirang khanzode]

yes, this works now on 0521 brnch on osx and 9.2. checked out flash , qktime and 
acrobat tests.

Comment 21

[Jaime Rodriguez, Jr.]

Removing "+" from Status Whiteboard, as the bugs are plussed by the ADT in the
Keywords.

Comment 22

[bmartin]

Marking this Verified Fixed
Testing against Mac OSX Mozilla 2003050803 trunk

Tested keyboard events with Full Screen QuickTime plugin successfully:
Go to: http://www.apple.com/trailers/disney/finding_nemo/trailer/ choose Full
Screen option

Tested keyboard events against Flash testcase in comment #9