1433205 - [iOS 11] Allow hyperlinks to be dragged and dropped into Firefox for iOS

Status: VERIFIED FIXED

(Firefox for iOS :: Browser, enhancement, P1)

Description

[Justin D'Arcangelo [:justindarc]]

iOS 11 introduced drag and drop APIs allowing content to be dragged and dropped between apps on iPad. Firefox for iOS should be able to receive hyperlinks/URLs to be dropped in from other apps.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

This patch enables our browser chrome to have hyperlinks/URLs dropped in from other apps. Hyperlinks/URLs can also be dropped anywhere on the home tab panel. The webview is not part of the drop target for this feature which enables hyperlinks/URLs to still be dragged into text fields inside of web content.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This looks great. I think we should land this and file followup bugs for the following two:

Safari allows links to be dropped anywhere in an already loaded page. It will make an exception for stuff dropped in form fields and text areas, but anything dropped in the 'white space' of a page will result in loading that url. This is why https://github.com/mozilla-mobile/firefox-ios/pull/3209 was written, but that is admittedly a pretty hacky (although working!) solution. I wonder if WebKit has a JS API that allows us to accept drops. We could install a default handler on pages to forward drops to Swift. I vaguely remember that Apple was talking about this in some document.

We should also accept a content type of text, which should translate to a search, just like Paste & Go does.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This seems to be added for the iOS 10 release:

https://developer.apple.com/library/content/documentation/AppleApplications/Conceptual/SafariJSProgTopics/DragAndDrop.html

Comment 4

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/8489c9b63e0a58ffc95a83611f4bd289aa2a145e

Landed on v11.x:

https://github.com/mozilla-mobile/firefox-ios/commit/d24c7a683518aa7d99fa06bcd001441f320104cb

Comment 5

[Simon Basca [:SimonB]]

Verifying as fix on 11.0(9148). Hyperlinks/URLs can be dropped in Firefox from other apps.