143328 - Need switch to hide misc panel on Form Manager

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect)

Description

[Ying-Lin Xia]

We had a switch in all.js before,
   pref("wallet.miscPanel.hide",               true);
but it's not working now, set it to "true" won't hide the "Personal" panel.

Reproducible: Always
Steps to Reproduce:
1. Set "wallet.miscPanel.hide" to true.
2. Launch Mozilla and start Tools/Form Manager/Edit Form Info.

Actual Results:  The "Personal" panel is still on the UI.

Expected Results:  It should be hidden.

Comment 1

[Ying-Lin Xia]

Attachment: Screenshot, "Personal" panel needs to be hidden for some countries.

Comment 2

[Stephen P. Morse]

Problem is that display:none has been deprecated in favor of hidden=true.  
Attaching a patch to update this file to use the latter method of hiding.

Comment 3

[Stephen P. Morse]

Attachment: display:none -> hidden=true

Comment 4

[jag (Peter Annema)]

Comment on attachment 83147 [details] [diff] [review]
display:none -> hidden=true

sr=jag

Comment 5

[Samir Gehani]

Comment on attachment 83147 [details] [diff] [review]
display:none -> hidden=true

r=sgehani

Comment 6

[Stephen P. Morse]

Checked in on trunk

Comment 7

[Frank Tang]

yxia- can you verify the fix is good?

Comment 8

[Ying-Lin Xia]

Verified in last night JA build, with morse's new checked in file, working good 
for Personal panel, didn't check others, but must be the same. Thanks a lot, 
morse.

Comment 9

[Jaime Rodriguez, Jr.]

teri - can you verify this on the trunk, and make sure no regressions were
introduced.

Comment 10

[Terri Preston]

Verified this is fixed on Win XP trunk build 2002051408, Mac OS X trunk build
2002051403 and linux trunk build 2002051409

Comment 11

[Frank Tang]

mark this bug as VERIFIED since it checked into the turnk and verified on the trunk.
Without that ADT may not adt+ it. 

Comment 12

[Frank Tang]

mark it verified since qa said so

Comment 13

[scottputterman]

adding adt1.0.0+.  Please get drivers approval before checking in to the 1.0
branch.  This can go in after RC3.

Comment 14

[Brendan Eich [:brendan]]

Comment on attachment 83147 [details] [diff] [review]
display:none -> hidden=true

a=[e-mail] on behalf of drivers for checkin to the 1.0 branch --
please check the patch in today, we're trying for rc3 based on tomorrow's
builds.  Thanks,

/be

Comment 15

[Stephen P. Morse]

Checked in on 1.0 branch.