Closed Bug 143328 Opened 22 years ago Closed 22 years ago

Need switch to hide misc panel on Form Manager

Categories

(Toolkit :: Form Manager, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: yinglinxia, Unassigned)

References

Details

(Keywords: intl, regression, Whiteboard: [adt2 rtm] [Needs a=] custrtm-)

Attachments

(2 files)

We had a switch in all.js before,
   pref("wallet.miscPanel.hide",               true);
but it's not working now, set it to "true" won't hide the "Personal" panel.

Reproducible: Always
Steps to Reproduce:
1. Set "wallet.miscPanel.hide" to true.
2. Launch Mozilla and start Tools/Form Manager/Edit Form Info.

Actual Results:  The "Personal" panel is still on the UI.

Expected Results:  It should be hidden.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: intl, nsbeta1, regression
Blocks: 141008
Problem is that display:none has been deprecated in favor of hidden=true.  
Attaching a patch to update this file to use the latter method of hiding.
Status: NEW → ASSIGNED
Comment on attachment 83147 [details] [diff] [review]
display:none -> hidden=true

sr=jag
Attachment #83147 - Flags: superreview+
Target Milestone: --- → mozilla1.0
Comment on attachment 83147 [details] [diff] [review]
display:none -> hidden=true

r=sgehani
Attachment #83147 - Flags: review+
Checked in on trunk
yxia- can you verify the fix is good?
Keywords: adt1.0.0
Verified in last night JA build, with morse's new checked in file, working good 
for Personal panel, didn't check others, but must be the same. Thanks a lot, 
morse.
teri - can you verify this on the trunk, and make sure no regressions were
introduced.
Keywords: approval
Whiteboard: [adt2 rtm] [Needs a=]
Verified this is fixed on Win XP trunk build 2002051408, Mac OS X trunk build
2002051403 and linux trunk build 2002051409
mark this bug as VERIFIED since it checked into the turnk and verified on the trunk.
Without that ADT may not adt+ it. 
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
mark it verified since qa said so
Status: RESOLVED → VERIFIED
adding adt1.0.0+.  Please get drivers approval before checking in to the 1.0
branch.  This can go in after RC3.
Keywords: adt1.0.0adt1.0.0+
Keywords: nsbeta1nsbeta1+
Comment on attachment 83147 [details] [diff] [review]
display:none -> hidden=true

a=brendan@mozilla.org on behalf of drivers for checkin to the 1.0 branch --
please check the patch in today, we're trying for rc3 based on tomorrow's
builds.  Thanks,

/be
Attachment #83147 - Flags: approval+
Checked in on 1.0 branch.
Keywords: fixed1.0.0
Blocks: 146292
No longer blocks: 141008
Whiteboard: [adt2 rtm] [Needs a=] → [adt2 rtm] [Needs a=] custrtm
Whiteboard: [adt2 rtm] [Needs a=] custrtm → [adt2 rtm] [Needs a=] custrtm-
Assignee: morse → nobody
Product: Core → Toolkit
QA Contact: tpreston → form.manager
Target Milestone: mozilla1.0 → ---
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: