Closed Bug 1433285 Opened 4 years ago Closed 4 years ago

Don't manually manage classes.dex when --with-gradle

Categories

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

enhancement
Not set
normal

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Right now, we maintain legacy manual classes.dex handling, even under --with-gradle.  That's not good for Bug 1414054 (which tracks adding support for multi-dex) and it's causing problems with Bug 1411654.

This ticket tracks extracting classes.dex from the Gradle-produced .ap_ at package time, avoiding the issue in https://bugzilla.mozilla.org/show_bug.cgi?id=1411654#c161.
Comment on attachment 8945630 [details]
Bug 1433285: Extract classes*.dex from .ap_ --with-gradle.

https://reviewboard.mozilla.org/r/215762/#review221496
Attachment #8945630 - Flags: review?(snorp) → review+
Comment on attachment 8945630 [details]
Bug 1433285: Extract classes*.dex from .ap_ --with-gradle.

https://reviewboard.mozilla.org/r/215762/#review222426
Attachment #8945630 - Flags: review+
Attachment #8945630 - Flags: review?(core-build-config-reviews)
Comment on attachment 8945630 [details]
Bug 1433285: Extract classes*.dex from .ap_ --with-gradle.

https://reviewboard.mozilla.org/r/215762/#review222434
Attachment #8945630 - Flags: review+
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53fa60c5e8b4
Extract classes*.dex from .ap_ --with-gradle. r=gps,snorp
https://hg.mozilla.org/mozilla-central/rev/53fa60c5e8b4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 60 → mozilla60
You need to log in before you can comment on or make changes to this bug.