Closed Bug 1433305 Opened 6 years ago Closed 6 years ago

Remove synchronous Bookmarks::GetItemLastModified

Categories

(Toolkit :: Places, enhancement, P1)

Product:
Toolkit
Component:
Places
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: mak, Assigned: mak)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsearch])

Attachments

(2 files)

Bug 1433305 - Remove a no more useful Places crash test.
59 bytes, text/x-review-board-request
standard8
: review+
Details
Bug 1433305 - Remove synchronous Bookmarks::GetItemLastModified.
59 bytes, text/x-review-board-request
standard8
: review+
Details
Whiteboard: [fx-search] → [fxsearch]
Comment on attachment 8949089 [details]
Bug 1433305 - Remove a no more useful Places crash test.

https://reviewboard.mozilla.org/r/218498/#review224276


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: toolkit/components/places/tests/unit/test_crash_476292.js:23
(Diff revision 1)
>    let dbFile = do_get_file("bug476292.sqlite");
>    let profD = Services.dirsvc.get(NS_APP_USER_PROFILE_50_DIR, Ci.nsIFile);
>    dbFile.copyTo(profD, "places.sqlite");
>  
>    // Now get the bookmarks service.  This will crash when the bug exists.
> -  Cc["@mozilla.org/browser/nav-bookmarks-service;1"].
> +  PlacesUtils.bookmarks.toolbarFolder

Error: Missing semicolon. [eslint: semi]
Comment on attachment 8949089 [details]
Bug 1433305 - Remove a no more useful Places crash test.

https://reviewboard.mozilla.org/r/218498/#review224516
Attachment #8949089 - Flags: review?(standard8) → review+
Comment on attachment 8949090 [details]
Bug 1433305 - Remove synchronous Bookmarks::GetItemLastModified.

https://reviewboard.mozilla.org/r/218500/#review224522
Attachment #8949090 - Flags: review?(standard8) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/2dde1dcdefa6
Remove a no more useful Places crash test. r=standard8
https://hg.mozilla.org/integration/autoland/rev/5f7ca17beb3d
Remove synchronous Bookmarks::GetItemLastModified. r=standard8
https://hg.mozilla.org/mozilla-central/rev/2dde1dcdefa6
https://hg.mozilla.org/mozilla-central/rev/5f7ca17beb3d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Depends on: 1438495
No longer depends on: 1438495
You need to log in before you can comment on or make changes to this bug.