1433305 - Remove synchronous Bookmarks::GetItemLastModified

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P1)

Description

[Marco Bonardo [:mak]]

Just a few tests
https://searchfox.org/mozilla-central/search?q=getItemLastModified(&path=

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1433305 - Remove a no more useful Places crash test.

Review commit: https://reviewboard.mozilla.org/r/218498/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218498/

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1433305 - Remove synchronous Bookmarks::GetItemLastModified.

Review commit: https://reviewboard.mozilla.org/r/218500/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218500/

Comment 3

[Code Review Bot [:reviewbot]]

Comment on attachment 8949089 [details]
Bug 1433305 - Remove a no more useful Places crash test.

https://reviewboard.mozilla.org/r/218498/#review224276


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: toolkit/components/places/tests/unit/test_crash_476292.js:23
(Diff revision 1)
>    let dbFile = do_get_file("bug476292.sqlite");
>    let profD = Services.dirsvc.get(NS_APP_USER_PROFILE_50_DIR, Ci.nsIFile);
>    dbFile.copyTo(profD, "places.sqlite");
>  
>    // Now get the bookmarks service.  This will crash when the bug exists.
> -  Cc["@mozilla.org/browser/nav-bookmarks-service;1"].
> +  PlacesUtils.bookmarks.toolbarFolder

Error: Missing semicolon. [eslint: semi]

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8949089 [details]
Bug 1433305 - Remove a no more useful Places crash test.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/218498/diff/1-2/

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 8949090 [details]
Bug 1433305 - Remove synchronous Bookmarks::GetItemLastModified.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/218500/diff/1-2/

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 8949090 [details]
Bug 1433305 - Remove synchronous Bookmarks::GetItemLastModified.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/218500/diff/2-3/

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8949089 [details]
Bug 1433305 - Remove a no more useful Places crash test.

https://reviewboard.mozilla.org/r/218498/#review224516

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8949090 [details]
Bug 1433305 - Remove synchronous Bookmarks::GetItemLastModified.

https://reviewboard.mozilla.org/r/218500/#review224522

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dde1dcdefa6
Remove a no more useful Places crash test. r=standard8
https://hg.mozilla.org/integration/autoland/rev/5f7ca17beb3d
Remove synchronous Bookmarks::GetItemLastModified. r=standard8

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2dde1dcdefa6
https://hg.mozilla.org/mozilla-central/rev/5f7ca17beb3d